chore(sns): kms key is not deleted in integ.sns.ts#29664
chore(sns): kms key is not deleted in integ.sns.ts#29664mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@jun1-t Could you change this to a |
xazhao
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for finding the issue.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #29663
Reason for this change
kms key created within integ test remains after integ test.
Description of changes
Added "pendingWindow" and "removalPolicy" to kms resource.
Description of how you validated changes
I confirmed with integ test that it works as expected.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license