Skip to content

feat(elasticloadbalancingv2): removeRuleSuffixFromLogicalId support#29745

Closed
ahammond wants to merge 1 commit intoaws:mainfrom
ahammond:logicalId-via-props
Closed

feat(elasticloadbalancingv2): removeRuleSuffixFromLogicalId support#29745
ahammond wants to merge 1 commit intoaws:mainfrom
ahammond:logicalId-via-props

Conversation

@ahammond
Copy link
Copy Markdown
Contributor

@ahammond ahammond commented Apr 5, 2024

No description provided.

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Apr 5, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 5, 2024 20:55
@ahammond ahammond closed this Apr 5, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #29746. Mergify cannot evaluate rules on this PR. ⚠️

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7b483b5
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants