feat(rds): implement setting parameter group name

[LaurenceWarne]

Reason for this change

I'd like to be able to set RDS parameter group names using CDK.

Description of changes

I've added a new field name to ParameterGroupProps used to populate dbClusterParameterGroupName and dbParameterGroupName where appropriate - AFAICS this couldn't be done at this level previously?

Description of how you validated changes

I've altered a couple of unit tests and an integration test. However I'm unable to run the integration test as the postgres version in the existing snapshot is deprecated (I believe this needs to be deployed before the new snapshot?) which blocks me from deploying.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[LaurenceWarne]

Clarification Request: please let me know what README changes you think would be appropriate 🙂

[paulhcsun]

Hi @LaurenceWarne, thank you for the contribution!

Regarding your clarification request, you could update the README here by adding the new name property to the sample code. It's a fairly simple change so that should be sufficient.

With regards to the integ test, I've pulled your code down and tested it an ran into the same issue. I was able to resolve it by doing 2 things:

1. Delete the existing snapshot folder for that integ test
2. Change the rds.PostgresEngineVersion to a supported version: ``rds.PostgresEngineVersion/VER_16_2and rerun the test with the--update-on-failed` flag to regenerate the new snapshots.

[LaurenceWarne]

With regards to the integ test, I've pulled your code down and tested it an ran into the same issue. I was able to resolve it by doing 2 things:

Delete the existing snapshot folder for that integ test
Change the rds.PostgresEngineVersion to a supported version: ``rds.PostgresEngineVersion/VER_16_2and rerun the test with the--update-on-failed` flag to regenerate the new snapshots.

Thanks for the guidance, should be done in the most recent commit!

If you like I can raise an issue for the other integration tests that use the same deprecated version.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[paulhcsun]

Suggested change

	* @default CloudFormation-generated name
	* @default - CloudFormation-generated name

Something I learned recently, if the value immediately after a @default tag is not the actual value but rather a sentence describing the value, you need to separate it with a dash - or else it would think that Cloudformation-generated is the default value.

Pull request has been modified.

[paulhcsun]

This looks good, nice work @LaurenceWarne!

And no worries, I can create an issue to update the existing integ tests using the deprecated postgres versions. Thanks again!

[paulhcsun]

@Mergifyio update

[mergify]

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[LaurenceWarne]

And no worries, I can create an issue to update the existing integ tests using the deprecated postgres versions. Thanks again!

Cool 👍. Do you need me to merge main - looks to be an issue with mergify?

[paulhcsun]

@Mergifyio update

[mergify]

update

☑️ Nothing to do

Details

• #commits-behind>0 [📌 update requirement]
• -closed [📌 update requirement]
• -conflict [📌 update requirement]
• queue-position=-1 [📌 update requirement]

Pull request has been modified.

[paulhcsun]

Reran, should hopefully work this time!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c281111
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[LaurenceWarne]

🎉 thanks!

[aws-cdk-automation]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.