Skip to content

chore(lambda): hide warning if skipPermissions is set#30060

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
daschaa:29887_lambda_permission_warning
May 6, 2024
Merged

chore(lambda): hide warning if skipPermissions is set#30060
mergify[bot] merged 2 commits intoaws:mainfrom
daschaa:29887_lambda_permission_warning

Conversation

@daschaa
Copy link
Copy Markdown
Contributor

@daschaa daschaa commented May 4, 2024

Issue #29887

Closes #29887

Reason for this change

If an user imports a lambda and wants to add permissions a warning is show. This warning should be skippable with the skipPermissions flag.

Description of how you validated changes

Unit tests for checking if the warning is shown/not shown depending on the value of skipPermissions are added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

If an user imports a lambda and wants to add permissions a warning is show. This warning should be skippable with the skipPermissions flag.
@aws-cdk-automation aws-cdk-automation requested a review from a team May 4, 2024 13:15
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels May 4, 2024
@daschaa
Copy link
Copy Markdown
Contributor Author

daschaa commented May 4, 2024

Exemption request - In my opinion this change neither needs an integration test nor an entry to the README.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 4, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 6, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 98e59ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2c53cf9 into aws:main May 6, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@daschaa daschaa deleted the 29887_lambda_permission_warning branch May 7, 2024 06:47
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-lambda: addPermission() warning should not be shown

3 participants