Skip to content

fix(events): detailType doesnt allow filtering patterns#30221

Closed
scub wants to merge 1 commit intoaws:mainfrom
scub:aws-events/filter-patterns-detailtype
Closed

fix(events): detailType doesnt allow filtering patterns#30221
scub wants to merge 1 commit intoaws:mainfrom
scub:aws-events/filter-patterns-detailtype

Conversation

@scub
Copy link
Copy Markdown
Contributor

@scub scub commented May 15, 2024

Issue # (if applicable)

Closes #30220

Reason for this change

Unable to use content based filtering patterns based on an events detailType using the events.Rule L2 construct without leveraging a trap door

Description of changes

Allow for the usage of content based filtering patterns based on an events detailType

Description of how you validated changes

Overall these are the steps that i've taken:

yarn install
npx lerna run build --scope=aws-cdk-lib
cd packages/aws-cdk-lib
npx yarn test aws-events
npx yarn lint aws-events
npx yarn eslint --fix aws-events/lib/event-pattern.ts aws-events/test/rule.test.ts

# Running integration tests
cd ../../
npx lerna run build --scope=@aws-cdk-testing/framework-integ
cd packages/@aws-cdk-testing/framework-integ
npx yarn integ test/aws-events/test/*.js --update-on-failed

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels May 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 15, 2024 20:09
@scub scub closed this May 15, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 58da09e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(events): Unable to use content based filtering patterns in detailType

2 participants