chore(rds): update engine versions by nmussy · Pull Request #30305 · aws/aws-cdk

nmussy · 2024-05-22T06:49:53Z

Issue # (if applicable)

None

Reason for this change

Update the CDK RDS engine versions to match the current availability, as well as facilitate automated alerts for updates in the future

Description of changes

Added missing engine version for all RDS engines
Added missing @deprecated TSDoc tags

Description of how you validated changes

The available versions were compared to live AWS API data. See #29422 for more details.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

nmussy · 2024-05-22T06:51:08Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

+  /** Version "5.7.44-rds.20240408". */
+  public static readonly VER_5_7_44_RDS_20240408 = MysqlEngineVersion.of('5.7.44-rds.20240408', '5.7');


See announcement

Seems like there is extended support for version 5.7.44-RDS.20240529 as well now, could we update this PR to include the latest versions?

Thanks for letting me know, I've updated them 👍

nmussy · 2024-05-22T06:51:31Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

+  /**
+   * Version "11.12-rds.20240418"
+   */
+  public static readonly VER_11_12_RDS_20240418 = PostgresEngineVersion.of('11.12-rds.20240418', '11', { s3Import: true, s3Export: true });


See announcement

Correct link: https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-rds-postgresql-extended-support-minor/

paulhcsun

Hi @nmussy, thanks for the contribution and updating these with the latest versions and deprecated ones. It looks like there is at least 1 new version that has been added since this PR was created, could you update it with the latest versions and then I'd be happy to approve and get this merged in after!

paulhcsun · 2024-06-24T21:49:20Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

+  /**
+   * Version "11.12-rds.20240418"
+   */
+  public static readonly VER_11_12_RDS_20240418 = PostgresEngineVersion.of('11.12-rds.20240418', '11', { s3Import: true, s3Export: true });


Correct link: https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-rds-postgresql-extended-support-minor/

paulhcsun · 2024-06-24T21:51:30Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

+  /** Version "5.7.44-rds.20240408". */
+  public static readonly VER_5_7_44_RDS_20240408 = MysqlEngineVersion.of('5.7.44-rds.20240408', '5.7');


Seems like there is extended support for version 5.7.44-RDS.20240529 as well now, could we update this PR to include the latest versions?

…ging-versions

msambol

LGTM 👍🏼

paulhcsun

Nice, thanks @nmussy!

paulhcsun · 2024-06-26T17:14:08Z

@Mergifyio update

mergify · 2024-06-26T17:14:33Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

mergify · 2024-06-26T17:14:34Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

paulhcsun · 2024-06-26T17:16:40Z

@Mergifyio update

mergify · 2024-06-26T17:16:57Z

update

☑️ Nothing to do

Details

#commits-behind>0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position=-1 [📌 update requirement]

mergify · 2024-06-26T17:46:49Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-06-26T18:52:27Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: b4d37ef
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-06-26T18:52:47Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-07-25T21:06:30Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

chore(rds): update engine versions

be51875

aws-cdk-automation requested a review from a team May 22, 2024 06:50

github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels May 22, 2024

nmussy commented May 22, 2024

View reviewed changes

docs: copypasta

93a32bd

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 22, 2024

This was referenced May 27, 2024

Weekly PR metrics report #30348

Closed

Monthly PR metrics report #30414

Closed

paulhcsun reviewed Jun 24, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into chore-rds-update-en…

2959529

…ging-versions

nmussy requested a review from paulhcsun June 25, 2024 05:55

chore: update versions

185f93d

nmussy force-pushed the chore-rds-update-enging-versions branch from 89a419e to 185f93d Compare June 25, 2024 06:14

msambol approved these changes Jun 26, 2024

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 26, 2024

mazyu36 mentioned this pull request Jun 26, 2024

chore(rds): add SQL Server versions 16.00.4115.5.v1 and 16.00.4120.1.v1 #30267

Closed

1 task

paulhcsun previously approved these changes Jun 26, 2024

View reviewed changes

Merge branch 'main' into chore-rds-update-enging-versions

de09b4f

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2024

paulhcsun approved these changes Jun 26, 2024

View reviewed changes

Merge branch 'main' into chore-rds-update-enging-versions

b4d37ef

mergify bot merged commit 064cec0 into aws:main Jun 26, 2024

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

		/** Version "5.7.44-rds.20240408". */
		public static readonly VER_5_7_44_RDS_20240408 = MysqlEngineVersion.of('5.7.44-rds.20240408', '5.7');

Conversation

nmussy commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

nmussy May 22, 2024

Choose a reason for hiding this comment

Uh oh!

paulhcsun Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

nmussy Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

nmussy May 22, 2024

Choose a reason for hiding this comment

Uh oh!

paulhcsun Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

paulhcsun left a comment

Choose a reason for hiding this comment

Uh oh!

paulhcsun Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

paulhcsun Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

msambol left a comment

Choose a reason for hiding this comment

Uh oh!

paulhcsun left a comment

Choose a reason for hiding this comment

Uh oh!

paulhcsun commented Jun 26, 2024

Uh oh!

mergify bot commented Jun 26, 2024

❌ Mergify doesn't have permission to update

Uh oh!

mergify bot commented Jun 26, 2024

Uh oh!

paulhcsun commented Jun 26, 2024

Uh oh!

mergify bot commented Jun 26, 2024

☑️ Nothing to do

Uh oh!

mergify bot commented Jun 26, 2024

Uh oh!

aws-cdk-automation commented Jun 26, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jun 26, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nmussy commented May 22, 2024 •

edited

Loading