feat(ec2): security group lookup by name, vpc, and owner#30334
feat(ec2): security group lookup by name, vpc, and owner#30334
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
…irle/aws-cdk into feat/ec2-lookup-sg-by-owner
|
Clarification Request Looking for some clarity on what else is needed for this - unit tests, integration tests, and codebuild test all seem to be passing. |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
|
Hi @eschirle, thank you for your contribution and the effort you've put into this PR. After reviewing, I noticed that a second PR (#30625) was opened after yours which provides a similar solution but allows filtering on additional properties which will be a better long term solution for looking up security groups. Therefore I will be closing this PR and proceed with the other. We appreciate your understanding. |

Issue
Closes #30331
Reason for this change
To allow
fromLookupByNameto filter security groups by owner.Description of changes
Adds an optional input to
fromLookupByNameand updates the security group context provider to support a filter on owner.Description of how you validated changes
Unit tests updated for
ec2.security-groupandcontext-providers.security-groupsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license