fix(ecs): removed omitEmptyArray for placementConstraints (#27555)#30382
Merged
mergify[bot] merged 1 commit intoaws:mainfrom May 30, 2024
Merged
fix(ecs): removed omitEmptyArray for placementConstraints (#27555)#30382mergify[bot] merged 1 commit intoaws:mainfrom
mergify[bot] merged 1 commit intoaws:mainfrom
Conversation
…ser to give empty values
github-actions
bot
added
p2
beginning-contributor
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
stm29
changed the title
aws-cdk-automation
added
the
pr/needs-community-review
This was referenced May 30, 2024
aws-cdk-automation
added
pr/needs-maintainer-review
moelasmar
approved these changes
May 30, 2024
Contributor
moelasmar
left a comment
moelasmar
left a comment
There was a problem hiding this comment.
it looks good, thanks for creating this PR
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
This was referenced Jun 1, 2024
vdahlberg
pushed a commit
to vdahlberg/aws-cdk
that referenced
this pull request
Jun 10, 2024
…aws#30382) ### Issue fixes aws#27555 Closes Half Fix [i.e, Allows user to give Empty Placement Constraints ] aws#27555 This PR does not address supporting empty placement strategies because of the following reason : [27555 : comment](aws#27572 (comment)) This was raised with the guidance from - [pr / 28431 : Comment ](aws#28431 (comment)) ### Reason for this change Users unable to give empty placementConstraints ### Description of how you validated changes - Added a UnitCase to cover with empty `[]` placementConstraints - Integration Tests ``` $ yarn integ test/aws-ecs/test/ec2/integ.placement-constraint-default-empty.js --update-on-failed ``` After integ tests were completed, `npm test` to verify the snapshot. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Jul 19, 2024
Collaborator
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
fixes #27555
Closes Half Fix [i.e, Allows user to give Empty Placement Constraints ] #27555
This PR does not address supporting empty placement strategies because of the following reason : 27555 : comment
This was raised with the guidance from - pr / 28431 : Comment
Reason for this change
Users unable to give empty placementConstraints
Description of how you validated changes
[]placementConstraintsAfter integ tests were completed,
npm testto verify the snapshot.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license