chore(lambda): update the fact tables and tests for lambda layers v0.102.1 by alexperez52 · Pull Request #30812 · aws/aws-cdk

alexperez52 · 2024-07-10T05:55:12Z

Update ADOT Lambda Layer ARNs for recent release
aws-observability/aws-otel-lambda#957

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

alexperez52 · 2024-07-15T17:09:56Z

Hi, waiting for review on this PR

scanlonp

Hey, looking good.

I see why the versions set to latest are being updated, but could you explain why the layers are being updated when they are set to a constant version - particularly the JavaSdkVersion layers.

scanlonp · 2024-07-17T00:10:12Z

packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts

+      'ap-northeast-1': 'arn:aws:lambda:ap-northeast-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'ap-northeast-2': 'arn:aws:lambda:ap-northeast-2:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'ap-south-1': 'arn:aws:lambda:ap-south-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'ap-southeast-1': 'arn:aws:lambda:ap-southeast-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'ap-southeast-2': 'arn:aws:lambda:ap-southeast-2:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'ca-central-1': 'arn:aws:lambda:ca-central-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'eu-central-1': 'arn:aws:lambda:eu-central-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'eu-north-1': 'arn:aws:lambda:eu-north-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'eu-west-1': 'arn:aws:lambda:eu-west-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'eu-west-2': 'arn:aws:lambda:eu-west-2:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'eu-west-3': 'arn:aws:lambda:eu-west-3:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'sa-east-1': 'arn:aws:lambda:sa-east-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'us-east-1': 'arn:aws:lambda:us-east-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'us-east-2': 'arn:aws:lambda:us-east-2:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'us-west-1': 'arn:aws:lambda:us-west-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+      'us-west-2': 'arn:aws:lambda:us-west-2:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3',
+    },
+    arm64: {
+      'ap-northeast-1': 'arn:aws:lambda:ap-northeast-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'ap-northeast-2': 'arn:aws:lambda:ap-northeast-2:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'ap-south-1': 'arn:aws:lambda:ap-south-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'ap-southeast-1': 'arn:aws:lambda:ap-southeast-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'ap-southeast-2': 'arn:aws:lambda:ap-southeast-2:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'ca-central-1': 'arn:aws:lambda:ca-central-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'eu-central-1': 'arn:aws:lambda:eu-central-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'eu-north-1': 'arn:aws:lambda:eu-north-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'eu-west-1': 'arn:aws:lambda:eu-west-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'eu-west-2': 'arn:aws:lambda:eu-west-2:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'eu-west-3': 'arn:aws:lambda:eu-west-3:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'sa-east-1': 'arn:aws:lambda:sa-east-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'us-east-1': 'arn:aws:lambda:us-east-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'us-east-2': 'arn:aws:lambda:us-east-2:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'us-west-1': 'arn:aws:lambda:us-west-1:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',
+      'us-west-2': 'arn:aws:lambda:us-west-2:901920570463:layer:aws-otel-java-wrapper-arm64-ver-1-32-0:3',


Where is this update coming from?

These are just our patch release version being updated but nothing was introduced. We tick the number up by one every release and conventionally also update it in layers. The constant is not updated as we have not introduced a minor version update

scanlonp · 2024-07-17T00:10:39Z

packages/aws-cdk-lib/aws-lambda/test/function.test.ts

    // THEN
    Template.fromStack(stack).hasResourceProperties('AWS::Lambda::Function', {
-      Layers: ['arn:aws:lambda:us-west-2:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:2'],
+      Layers: ['arn:aws:lambda:us-west-2:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-32-0:3'],


Shows up here.

scanlonp

Thanks for the explanation @alexperez52, looks good!

mergify · 2024-07-18T17:55:07Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

alexperez52 · 2024-07-18T20:05:21Z

Hi @scanlonp
There was an error in the checks: https://github.com/aws/aws-cdk/pull/30812/checks?check_run_id=27630417013
Not sure what causes or how to fix, but I synced the branch with :main and requires review again. Apologies if I did something wrong.
Allow edits by maintainers box is checked

aws-cdk-automation · 2024-07-18T20:17:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 35d5fd6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-07-18T20:46:00Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

scanlonp · 2024-07-18T20:48:24Z

Hey @alexperez52, no worries. Essentially what happens is when our workflows change, mergify loses permissions (for security reasons). Usually mergify does the branch merge automatically, but in these cases we (you or I) need to do it manually. That dismisses the reviews.

This is pretty normal, and we just need to click approve again! Looks like its in already in the time it took me to write this :)

aws-cdk-automation · 2024-07-25T17:42:30Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

Update the fact tables and tests for lambda layers v0.102.1

b2dccd5

github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 10, 2024

aws-cdk-automation requested a review from a team July 10, 2024 05:55

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 10, 2024

github-actions bot mentioned this pull request Jul 15, 2024

Weekly PR metrics report #30858

Closed

scanlonp reviewed Jul 17, 2024

View reviewed changes

scanlonp previously approved these changes Jul 18, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2024

scanlonp changed the title ~~chore(cdk): update the fact tables and tests for lambda layers v0.102.1~~ chore(lambda): update the fact tables and tests for lambda layers v0.102.1 Jul 18, 2024

Merge branch 'aws:main' into Adotlambda1021

4b49824

Merge branch 'main' into Adotlambda1021

35d5fd6

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2024

scanlonp approved these changes Jul 18, 2024

View reviewed changes

mergify bot merged commit d918499 into aws:main Jul 18, 2024

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2024

alexperez52 deleted the Adotlambda1021 branch July 18, 2024 20:59

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(lambda): update the fact tables and tests for lambda layers v0.102.1#30812

chore(lambda): update the fact tables and tests for lambda layers v0.102.1#30812
mergify[bot] merged 3 commits intoaws:mainfrom
alexperez52:Adotlambda1021

alexperez52 commented Jul 10, 2024 •

edited by scanlonp

Loading

Uh oh!

alexperez52 commented Jul 15, 2024

Uh oh!

scanlonp left a comment

Uh oh!

scanlonp Jul 17, 2024

Uh oh!

alexperez52 Jul 18, 2024

Uh oh!

scanlonp Jul 17, 2024

Uh oh!

scanlonp left a comment

Uh oh!

mergify bot commented Jul 18, 2024

Uh oh!

alexperez52 commented Jul 18, 2024

Uh oh!

aws-cdk-automation commented Jul 18, 2024

Uh oh!

mergify bot commented Jul 18, 2024

Uh oh!

scanlonp commented Jul 18, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alexperez52 commented Jul 10, 2024 • edited by scanlonp Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexperez52 commented Jul 15, 2024

Uh oh!

scanlonp left a comment

Choose a reason for hiding this comment

Uh oh!

scanlonp Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

alexperez52 Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

scanlonp Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

scanlonp left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jul 18, 2024

Uh oh!

alexperez52 commented Jul 18, 2024

Uh oh!

aws-cdk-automation commented Jul 18, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jul 18, 2024

Uh oh!

scanlonp commented Jul 18, 2024

Uh oh!

aws-cdk-automation commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexperez52 commented Jul 10, 2024 •

edited by scanlonp

Loading