fix(dependencies): @types/glob latest versions do not work with Minimatch. Removed refer…#33231
fix(dependencies): @types/glob latest versions do not work with Minimatch. Removed refer…#33231QuantumNeuralCoder wants to merge 1 commit intomainfrom
Conversation
…ences to @types/glob from CDK tools. Added dependency glob. Fixed Promise code to use async api from new dependency glob in cdk-copy.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33231 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 232 232
Lines 14106 14106
Branches 2452 2452
=======================================
Hits 11397 11397
Misses 2429 2429
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Echoing what Momo is saying. Unless there is a very good reason to upgrade (i.e., CVE, missing feature), the solution to all of these upgrade woes is to... not do it! So let's not upgrade |
|
Ack. Do we have a plan to handle these? #33168 |
Interesting. Other than the build error, there's nothing indicating how the upgrade dependencies PR is causing that problem. The general approach would be to upgrade all the dependency, except the ones that are causing an issue. And to prevent this from happening again tomorrow you would exclude the offending dependency form upgrades. Alternatively |
|
Comments on closed issues and PRs are hard for our team to see. |
@types/glob latest versions do not work with Minimatch.
So removed references to @types/glob from CDK tools. Added dependency glob. This was as per recommendation from the author.
Fixed Promise code to use async api from new dependency glob in cdk-copy.
Issue # (if applicable)
None
Closes #
Build issues for #33168
Reason for this change
Build is broken since @types/glob latest versions do not work with Minimatch latest version due to breaking changes. The author of @types/glob has rewritten the module and released in Glob.
Updating the references and removing the old dependency caused an error in its usage in