feat(rds): DatabaseCluster support replicationSourceIdentifier

[phuhung273]

Issue # (if applicable)

Closes #33280

Description of changes

• DatabaseCluster support replicationSourceIdentifier
• Validate replicationSourceIdentifier cannot be used with credentials

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (d580853) to head (f2e31a8).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33471   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.21% <ø> (ø)

[GavinZZ]

Is this check canHaveCredentials still needed when you already did the validation in packages/aws-cdk-lib/aws-rds/lib/validate-database-cluster-props.ts?

[phuhung273]

Yes because of 2 reasons:

• To use read replica, we have to explicitly give masterUsername and masterUserPassword as undefined
• User cannot turn it off, credentials is always defined

  aws-cdk/packages/aws-cdk-lib/aws-rds/lib/private/util.ts

  Line 89 in 7be47e1

  let renderedCredentials = credentials ?? Credentials.fromUsername(engine.defaultUsername ?? 'admin'); // For backwards compatibilty

So the purpose of canHaveCredentials check is to switch off credentials, while packages/aws-cdk-lib/aws-rds/lib/validate-database-cluster-props.ts is to validate

[GavinZZ]

Thank you!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f2e31a8
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.