feat(kinesisfirehose): add built-in data processors to decompress CloudWatch logs and extract messages#33749
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33749 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 120 120
Lines 6960 6960
Branches 1175 1175
=======================================
Hits 5735 5735
Misses 1120 1120
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Hi @Tietew, since this is a stable library we cannot accept any breaking changes. I think the best thing to do is deprecate the property in the interface and then just return some empty object or undefined and update the logic in the processIdentifier is empty and ignore that case. Let me know what you think.
|
|
@paulhcsun Thank you for comment. |
Pull request has been modified.
2f81977 to
466780b
Compare
packages/aws-cdk-lib/aws-kinesisfirehose/lib/private/helpers.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
|
LGTM. Thanks! |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated
You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated
You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33691.
Closes #20242.
Reason for this change
Data Firehose supports following convenient conversions:
This PR adds above 3 processors because:
Description of changes
processors(plural) prop to specify multiple processorsprocessor(singular) prop in favor ofprocessorsDecompressionProcessor- Decompress CloudWatch logsCloudWatchLogProcessor- Extract message after decompression of CloudWatch LogsAppendDelimiterToRecordProcessor- Add a new line delimiter when delivering data to Amazon S3Describe any new or updated permissions being added
N/A - No permissions are required by these built-in processors.
Description of how you validated changes
Added unit tests and integ tests
see also #33691 (comment)
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license