Skip to content

feat(kinesisfirehose): add built-in data processors to decompress CloudWatch logs and extract messages#33749

Merged
mergify[bot] merged 39 commits intoaws:mainfrom
Tietew:firehose-processors
Oct 30, 2025
Merged

feat(kinesisfirehose): add built-in data processors to decompress CloudWatch logs and extract messages#33749
mergify[bot] merged 39 commits intoaws:mainfrom
Tietew:firehose-processors

Conversation

@Tietew
Copy link
Copy Markdown
Contributor

@Tietew Tietew commented Mar 12, 2025

Issue # (if applicable)

Closes #33691.
Closes #20242.

Reason for this change

Data Firehose supports following convenient conversions:

This PR adds above 3 processors because:

  • Decompression (without CloudWatchLogProcessing) may need AppendDelimiterToRecord
  • CloudWatchLogProcessing requires Decompression

Description of changes

  • introduce processors (plural) prop to specify multiple processors
  • deprecate processor (singular) prop in favor of processors
  • add built-in processor classes:
    • DecompressionProcessor - Decompress CloudWatch logs
    • CloudWatchLogProcessor - Extract message after decompression of CloudWatch Logs
    • AppendDelimiterToRecordProcessor - Add a new line delimiter when delivering data to Amazon S3

Describe any new or updated permissions being added

N/A - No permissions are required by these built-in processors.

Description of how you validated changes

Added unit tests and integ tests

see also #33691 (comment)

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 12, 2025 11:28
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Mar 12, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (be383a9) to head (a4d86ac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33749   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         120      120           
  Lines        6960     6960           
  Branches     1175     1175           
=======================================
  Hits         5735     5735           
  Misses       1120     1120           
  Partials      105      105           
Flag Coverage Δ
suite.unit 82.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.39% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tietew

This comment was marked as resolved.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Mar 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 13, 2025 03:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Tietew Tietew marked this pull request as ready for review March 13, 2025 03:01
@Tietew Tietew changed the title feat(kinesisfirehose): add built-in data processors: Decompression, CloudWatchProcessing, and AppendDelimiterToRecord feat(kinesisfirehose): add built-in data processors to decompress CloudWatch logs and extract messages Mar 13, 2025
@paulhcsun paulhcsun self-assigned this Mar 13, 2025
@paulhcsun
Copy link
Copy Markdown
Contributor

paulhcsun commented Mar 14, 2025

Hi @Tietew, since this is a stable library we cannot accept any breaking changes. I think the best thing to do is deprecate the property in the interface and then just return some empty object or undefined and update the logic in the renderDataProcessor method

to ignore this case if the processIdentifier is empty and ignore that case. Let me know what you think.

@paulhcsun paulhcsun removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Mar 14, 2025
@Tietew
Copy link
Copy Markdown
Contributor Author

Tietew commented Mar 15, 2025

@paulhcsun Thank you for comment.
I'll update to return empty duumy object instead of undefined.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 22, 2025
@mergify mergify bot dismissed Abogical’s stale review October 28, 2025 04:16

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 28, 2025
@Tietew Tietew force-pushed the firehose-processors branch from 2f81977 to 466780b Compare October 30, 2025 09:52
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 30, 2025
@mergify mergify bot dismissed Abogical’s stale review October 30, 2025 13:38

Pull request has been modified.

@Abogical
Copy link
Copy Markdown
Member

LGTM. Thanks!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

rebase conflict between base and head.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Tietew
Copy link
Copy Markdown
Contributor Author

Tietew commented Oct 30, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

rebase conflict between base and head.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Tietew
Copy link
Copy Markdown
Contributor Author

Tietew commented Oct 30, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5dec21e into aws:main Oct 30, 2025
19 of 20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2025
@Tietew Tietew deleted the firehose-processors branch October 31, 2025 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

7 participants