Skip to content

feat(events-target): SNSTopic support role#33976

Closed
phuhung273 wants to merge 4 commits intoaws:mainfrom
phuhung273:events-sns-target-role
Closed

feat(events-target): SNSTopic support role#33976
phuhung273 wants to merge 4 commits intoaws:mainfrom
phuhung273:events-sns-target-role

Conversation

@phuhung273
Copy link
Copy Markdown
Contributor

Issue # (if applicable)

Closes #33827

Description of changes

  • SNSTopic support specifying IAM role

Describe any new or updated permissions being added

Specified IAM Role will automatically be granted sns:Publish on the topic

Description of how you validated changes

Unit + Integ

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 30, 2025 03:56
@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Mar 30, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (a67c3f5) to head (3476ba7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33976   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         120      120           
  Lines        6960     6960           
  Branches     1175     1175           
=======================================
  Hits         5735     5735           
  Misses       1120     1120           
  Partials      105      105           
Flag Coverage Δ
suite.unit 82.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.39% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4314aec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@phuhung273 phuhung273 closed this Jun 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2025
@phuhung273 phuhung273 deleted the events-sns-target-role branch September 12, 2025 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws_events_targets): ( for SNS target there is no option to mention execution role)

2 participants