Skip to content

chore(ecs): update instance-drain-hook lambda runtime to python 3.13 (closes #34634)#34639

Closed
its-felix wants to merge 2 commits intoaws:mainfrom
its-felix:34634-AwsEcsDrainHookLambdaRuntime
Closed

chore(ecs): update instance-drain-hook lambda runtime to python 3.13 (closes #34634)#34639
its-felix wants to merge 2 commits intoaws:mainfrom
its-felix:34634-AwsEcsDrainHookLambdaRuntime

Conversation

@its-felix
Copy link
Copy Markdown

@its-felix its-felix commented Jun 5, 2025 •
edited
Loading

Issue # (if applicable)

Closes #34634.

Reason for this change

The old Lambda Runtime Python 3.9 is being deprecated

Description of changes

  • Update Lambda Runtime to Python 3.13 (newest currently supported)
  • Fixed a minor logging bug in the lambda code
  • Added Runtime-Property assertion to unit tests
  • Updated Runtime-Property assertion in integ tests

Describe any new or updated permissions being added

None

Description of how you validated changes

(cd packages/aws-cdk-lib && yarn test aws-ecs)

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 5, 2025 16:40
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Jun 5, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 5, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@its-felix its-felix force-pushed the 34634-AwsEcsDrainHookLambdaRuntime branch from 8f21b05 to be8acfd Compare June 5, 2025 17:02
@its-felix its-felix changed the title feat(aws-ecs): update instance-drain-hook lambda runtime to python 3.13 (closes #34634) chore(aws-ecs): update instance-drain-hook lambda runtime to python 3.13 (closes #34634) Jun 5, 2025
@its-felix its-felix changed the title chore(aws-ecs): update instance-drain-hook lambda runtime to python 3.13 (closes #34634) chore(ecs): update instance-drain-hook lambda runtime to python 3.13 (closes #34634) Jun 5, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 5, 2025 17:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@its-felix its-felix marked this pull request as ready for review June 5, 2025 17:06
@its-felix its-felix force-pushed the 34634-AwsEcsDrainHookLambdaRuntime branch 3 times, most recently from 142d99f to 0b257dd Compare June 6, 2025 21:57
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 6, 2025
@its-felix its-felix force-pushed the 34634-AwsEcsDrainHookLambdaRuntime branch from 0b257dd to a257b45 Compare June 10, 2025 23:14
laurelmay
laurelmay approved these changes Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@laurelmay laurelmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this update!

@its-felix its-felix force-pushed the 34634-AwsEcsDrainHookLambdaRuntime branch from a257b45 to 4294dcd Compare June 18, 2025 15:26
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 18, 2025
@its-felix its-felix force-pushed the 34634-AwsEcsDrainHookLambdaRuntime branch from 4294dcd to 0ee8344 Compare June 24, 2025 02:34
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Closed
@Abogical Abogical self-assigned this Jul 4, 2025
Abogical
Abogical previously requested changes Jul 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Abogical Abogical left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I'm requesting a small change to it.

@mergify mergify bot dismissed Abogical’s stale review July 28, 2025 08:07

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 28, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 029c125
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Abogical Abogical mentioned this pull request Jul 29, 2025
Merged
1 task
@Abogical
Copy link
Copy Markdown
Member

Abogical commented Jul 29, 2025

Closed in favour of #35103

@Abogical Abogical closed this Jul 29, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 29, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2025
@aws aws unlocked this conversation Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abogical Abogical Abogical left review comments

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

+1 more reviewer

@laurelmay laurelmay laurelmay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Abogical Abogical

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-ecs: Update Lambda Runtime Version for instance-drain-hook.ts

4 participants

@its-felix @aws-cdk-automation @Abogical @laurelmay