Skip to content

fix(s3-deployment): remove .js,.d.ts file from git#35069

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
phuhung273:remove-s3-deployment-js-file
Jul 25, 2025
Merged

fix(s3-deployment): remove .js,.d.ts file from git#35069
mergify[bot] merged 2 commits intoaws:mainfrom
phuhung273:remove-s3-deployment-js-file

Conversation

@phuhung273
Copy link
Copy Markdown
Contributor

Issue # (if applicable)

Closes #35066

Reason for this change

All PRs blocked from merging

Description of changes

Remove .js, .d.ts file from version control

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 25, 2025 12:36
@github-actions github-actions bot added bug This issue is a bug. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jul 25, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e534e8d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ozelalisen ozelalisen added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 25, 2025
Copy link
Copy Markdown
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your proactive contribution on this issue :)

@phuhung273
Copy link
Copy Markdown
Contributor Author

Thanks for taking a look @ozelalisen 🚀

@aws-cdk-automation aws-cdk-automation dismissed their stale review July 25, 2025 13:34

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6743acb into aws:main Jul 25, 2025
31 checks passed
@phuhung273 phuhung273 deleted the remove-s3-deployment-js-file branch July 25, 2025 13:35
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(s3-deployment): integ js file integ.bucket-deployment-signcontent.js commited, blocking all PR from merging

3 participants