Closed
Conversation
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mazyu36
suggested changes
Jul 28, 2025
Contributor
mazyu36
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
Just for clarification, can this enum be used for deployment?
I think 5.7.12 was deprecated long ago, so this enum cannot be used anymore.
Could you please let me know what use cases this change is intended for?
Contributor
|
Thanks for the contribution! Right now the only my SQL Extended support Could you please let me know what use cases this change is intended for? |
Contributor
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
MySQL 5.7.12 version is missing from the AWS CDK MySQL engine versions. The current CDK library starts from MySQL 5.7.16, leaving 5.7.12 undefined despite AWS RDS supporting this version.
Description of changes
Changes made:
packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts@deprecatedannotation consistent with other deprecated 5.7.x versionsWhy these changes address the issue:
Alternatives considered and rejected:
Design decisions:
MysqlEngineVersion.of('5.7.12', '5.7')formatDescribe any new or updated permissions being added
No new IAM permissions are required for this change. Only existing RDS-related permissions are used.
Description of how you validated changes
Validation methods:
Testing:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license