Skip to content

chore(rds): add MySQL 5.7.12 version#35074

Closed
AkitoAndo wants to merge 1 commit intoaws:mainfrom
AkitoAndo:update/add-rds-mysql-versions
Closed

chore(rds): add MySQL 5.7.12 version#35074
AkitoAndo wants to merge 1 commit intoaws:mainfrom
AkitoAndo:update/add-rds-mysql-versions

Conversation

@AkitoAndo
Copy link
Copy Markdown

Issue # (if applicable)

Closes #.

Reason for this change

MySQL 5.7.12 version is missing from the AWS CDK MySQL engine versions. The current CDK library starts from MySQL 5.7.16, leaving 5.7.12 undefined despite AWS RDS supporting this version.

Description of changes

Changes made:

  • Added MySQL 5.7.12 version to packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts
  • Positioned it appropriately before MySQL 5.7.16 to maintain version ordering
  • Added @deprecated annotation consistent with other deprecated 5.7.x versions

Why these changes address the issue:

  • AWS RDS supports MySQL 5.7.12, but it's not defined in the CDK library
  • Maintains consistency with existing codebase by adding the deprecated marker
  • Preserves version ordering by placing it before 5.7.16

Alternatives considered and rejected:

  • Considered adding without deprecated marker, but rejected to maintain consistency with all other 5.7.x versions which have deprecated markers

Design decisions:

  • Followed existing code pattern using MysqlEngineVersion.of('5.7.12', '5.7') format
  • Unified comment style with other version definitions

Describe any new or updated permissions being added

No new IAM permissions are required for this change. Only existing RDS-related permissions are used.

Description of how you validated changes

Validation methods:

  1. Code review: Verified consistency with existing MySQL version definitions
  2. Syntax check: Confirmed no TypeScript syntax errors
  3. Pattern matching: Verified definition follows the same pattern as other deprecated versions

Testing:

  • Manually reviewed code to ensure it follows existing patterns
  • Verified correct version ordering placement

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 26, 2025 15:41
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 26, 2025
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a9407f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 26, 2025
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
Just for clarification, can this enum be used for deployment?
I think 5.7.12 was deprecated long ago, so this enum cannot be used anymore.
Could you please let me know what use cases this change is intended for?

@gasolima
Copy link
Copy Markdown
Contributor

gasolima commented Aug 25, 2025

Thanks for the contribution!

Right now the only my SQL Extended support
is 5.7.44. So the 5.7.12 isn't supported anymore.

Could you please let me know what use cases this change is intended for?

@gasolima gasolima self-assigned this Aug 25, 2025
@gasolima gasolima added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 25, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Aug 27, 2025
@github-actions github-actions bot closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants