fix(ecs): prevent unnecessary updates when setting availabilityZoneRe…#35077
Open
fix(ecs): prevent unnecessary updates when setting availabilityZoneRe…#35077
Conversation
github-actions
bot
added
beginning-contributor
aws-cdk-automation
previously requested changes
Jul 27, 2025
AkitoAndo
force-pushed
the
fix/ecs-availability-zone-rebalancing-default
branch
from
56c9401 to
03de97b
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AkitoAndo
force-pushed
the
fix/ecs-availability-zone-rebalancing-default
branch
3 times, most recently
from
aada440 to
884c6a9
Compare
…balancing=DISABLED
AkitoAndo
force-pushed
the
fix/ecs-availability-zone-rebalancing-default
branch
from
884c6a9 to
3377b14
Compare
…balancing=DISABLED
AkitoAndo
force-pushed
the
fix/ecs-availability-zone-rebalancing-default
branch
from
41774d5 to
9af8ce6
Compare
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…DISABLED Updated integration test snapshots to reflect the correct behavior where AvailabilityZoneRebalancing property should be omitted from CloudFormation template when set to DISABLED, preventing unnecessary service updates.
Updated the integration test snapshot to reflect the current test code which specifies memoryLimitMiB: 512. This aligns the snapshot with the actual test implementation.
This was referenced Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AvailabilityZoneRebalancing explicitly causing task replacement
Closes #35051.
Reason for this change
When availabilityZoneRebalancing is explicitly set to DISABLED (the default value),
CloudFormation includes the property in the template, causing unnecessary service
updates and task replacement.
Description of changes
Modified FargateService and Ec2Service to only include availabilityZoneRebalancing
in CloudFormation template when explicitly set to ENABLED. This prevents
CloudFormation changes when the default DISABLED value is explicitly set.
Added test cases to verify the fix works correctly.
Description of how you validated changes
Added unit tests for both FargateService and Ec2Service to verify that: