chore(custom-resources): correct JSDoc deprecated property names in ProviderProps#35110
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Jul 31, 2025
Merged
chore(custom-resources): correct JSDoc deprecated property names in ProviderProps#35110mergify[bot] merged 3 commits intoaws:mainfrom
mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
…viderProps Fixes aws#35049 The deprecated 'role' property in ProviderProps interface had incorrect JSDoc @deprecated comment referencing non-existent property names: - frameworkOnEventLambdaRole (incorrect) - frameworkIsCompleteLambdaRole (incorrect) - frameworkOnTimeoutLambdaRole (incorrect) Updated to reference the correct property names: - frameworkOnEventRole - frameworkCompleteAndTimeoutRole This improves developer experience by providing accurate migration guidance when using the deprecated role property.
kumsmrit
approved these changes
Jul 31, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35049
The deprecated 'role' property in ProviderProps interface had incorrect JSDoc @deprecated comment referencing non-existent property names:
Updated to reference the correct property names:
This improves developer experience by providing accurate migration guidance when using the deprecated role property.
Issue # (if applicable)
Closes #35049.
Reason for this change
The JSDoc
@deprecatedcomment for theroleproperty in theProviderPropsinterface contained incorrect property names that don't exist in the interface. This misleads developers who are trying to migrate away from the deprecated property, causing confusion and potential implementation errors.Description of changes
Files Modified:
packages/aws-cdk-lib/custom-resources/lib/provider-framework/provider.ts(line 126)Changes Made:
Updated the JSDoc
@deprecatedcomment from:To:
Why these changes address the issue:
frameworkOnEventRoleandframeworkCompleteAndTimeoutRole) actually exist in theProviderPropsinterfacerolepropertyAlternatives considered:
Design decisions:
Describe any new or updated permissions being added
No new or updated IAM permissions are needed. This is a documentation-only change that corrects JSDoc comments.
Description of how you validated changes
Build Validation:
yarn buildin custom-resources)Property Name Verification:
frameworkOnEventRoleexists in theProviderPropsinterface (lines 147-154)frameworkCompleteAndTimeoutRoleexists in theProviderPropsinterface (lines 156-166)packages/aws-cdk-lib/custom-resources/test/provider-framework/provider.test.ts)Documentation Impact:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license