chore(iot): cannot set a value greater than 3650 days for deviceCertificateAgeCheckDuration#35365
Merged
mergify[bot] merged 5 commits intoaws:mainfrom Sep 2, 2025
Merged
Conversation
aws-cdk-automation
previously requested changes
Aug 29, 2025
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
alvazjor
previously approved these changes
Sep 1, 2025
Pull request has been modified.
alvazjor
previously approved these changes
Sep 2, 2025
Pull request has been modified.
alvazjor
previously approved these changes
Sep 2, 2025
Pull request has been modified.
alvazjor
approved these changes
Sep 2, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
deviceCertificateAgeCheckDurationhas a upper bound value (3652 days) but we cannot deployAccountAuditConfigurationconstruct when this duration is set 3651-3652 days.AWS docs states that upper bound value is 3652 days but I think this statement is wrong.
Description of changes
Describe any new or updated permissions being added
None
Description of how you validated changes
update unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license