Skip to content

chore: improve reliability of lazify tests#35398

Merged
mergify[bot] merged 4 commits intomainfrom
huijbers/lazify-oopsie
Sep 3, 2025
Merged

chore: improve reliability of lazify tests#35398
mergify[bot] merged 4 commits intomainfrom
huijbers/lazify-oopsie

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Sep 2, 2025

Test suites execute in parallel, and two different test suites write the same file to disk in the same location, thereby racing.

Make them write different files.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Test suites execute in parallel, and two different test suites write
the same file to disk in the same location, thereby racing.

Make them write different files.
@rix0rrr rix0rrr requested review from a team September 2, 2025 13:04
@github-actions github-actions bot added the p2 label Sep 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 2, 2025 13:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 2, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 2, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr
Copy link
Copy Markdown
Contributor Author

rix0rrr commented Sep 3, 2025

@mergify requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 3, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 04eae8c into main Sep 3, 2025
19 of 20 checks passed
@mergify mergify bot deleted the huijbers/lazify-oopsie branch September 3, 2025 08:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants