feat(synthetics): allow root level canary scripts files for Puppeteer versions 11 and greater#35426
Conversation
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
This is a feat not a chore. Please update the title, that will also require you to add integ tests and readme changes. |
e3810a1 to
4259d3d
Compare
d197e9e to
b5b03eb
Compare
272b340 to
343fec5
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
343fec5 to
27c5cb1
Compare
27c5cb1 to
fcfe733
Compare
fcfe733 to
fcc217d
Compare
9a68965 to
235ecac
Compare
235ecac to
2b7f8e8
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: Pull request #35426 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "validate-pr" is queued.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
Support packaging structure changes for new runtimes based on NodeJS runtime Puppeteer framework
Description of changes
As part of the new Puppeteer based runtimes (
syn-nodesj-puppeteer-11.0and greater), users can have the canary script files in the root directory and are not required to use thenodejs/node_modulessub-directory to include the canary scripts. This PR ensures that we do not throw validation exception when users have their canary script in the root directory.Current requirement for the folder structure for Puppeteer based runtimes
Canary/nodejs/node_modules/index.jsWith the above changes, along with the above structure support, we also support
Canary/index.jsDescribe any new or updated permissions being added
No new permission have been added
Description of how you validated changes
Validated the changes by creating a sample canary with the changes in place and ensured that we are able to create canaries on runtime version
syn-nodejs-puppeteer-11.0with theindex.jsfiles in the root directory as well asindex.jsfile being present in thenodejs/node_modulessubdirectory inside the root directory.Added corresponding unit tests and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license