Skip to content

feat(synthetics): allow root level canary scripts files for Puppeteer versions 11 and greater#35426

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
nithinv13:puppeteer_packaging_structure
Oct 10, 2025
Merged

feat(synthetics): allow root level canary scripts files for Puppeteer versions 11 and greater#35426
mergify[bot] merged 2 commits intoaws:mainfrom
nithinv13:puppeteer_packaging_structure

Conversation

@nithinv13
Copy link
Copy Markdown
Contributor

@nithinv13 nithinv13 commented Sep 5, 2025

Issue # (if applicable)

Closes #.

Reason for this change

Support packaging structure changes for new runtimes based on NodeJS runtime Puppeteer framework

Description of changes

As part of the new Puppeteer based runtimes (syn-nodesj-puppeteer-11.0 and greater), users can have the canary script files in the root directory and are not required to use the nodejs/node_modules sub-directory to include the canary scripts. This PR ensures that we do not throw validation exception when users have their canary script in the root directory.

Current requirement for the folder structure for Puppeteer based runtimes
Canary/nodejs/node_modules/index.js

With the above changes, along with the above structure support, we also support
Canary/index.js

Describe any new or updated permissions being added

No new permission have been added

Description of how you validated changes

Validated the changes by creating a sample canary with the changes in place and ensured that we are able to create canaries on runtime version syn-nodejs-puppeteer-11.0 with the index.js files in the root directory as well as index.js file being present in the nodejs/node_modules subdirectory inside the root directory.

Added corresponding unit tests and integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 5, 2025 22:20
@github-actions github-actions bot added the p2 label Sep 5, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@nithinv13 nithinv13 changed the title chore: Allow root level canary scripts files for Puppeteer versions 11 and greater chore: allow root level canary scripts files for Puppeteer versions 11 and greater Sep 5, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 5, 2025 22:45

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aemada-aws
Copy link
Copy Markdown
Contributor

This is a feat not a chore. Please update the title, that will also require you to add integ tests and readme changes.

@aemada-aws aemada-aws self-assigned this Oct 2, 2025
@nithinv13 nithinv13 changed the title chore: allow root level canary scripts files for Puppeteer versions 11 and greater feat: allow root level canary scripts files for Puppeteer versions 11 and greater Oct 7, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 7, 2025
@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch from e3810a1 to 4259d3d Compare October 7, 2025 00:36
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch 3 times, most recently from d197e9e to b5b03eb Compare October 7, 2025 00:52
@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch 3 times, most recently from 272b340 to 343fec5 Compare October 7, 2025 18:50
@nithinv13 nithinv13 had a problem deploying to deployment-integ-test October 7, 2025 18:50 — with GitHub Actions Error
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 7, 2025 18:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch from 343fec5 to 27c5cb1 Compare October 8, 2025 02:48
@nithinv13 nithinv13 had a problem deploying to deployment-integ-test October 8, 2025 02:48 — with GitHub Actions Error
@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch from 27c5cb1 to fcfe733 Compare October 8, 2025 04:09
@nithinv13 nithinv13 had a problem deploying to deployment-integ-test October 8, 2025 04:10 — with GitHub Actions Error
@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch from fcfe733 to fcc217d Compare October 8, 2025 23:40
@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch from 9a68965 to 235ecac Compare October 9, 2025 02:49
@nithinv13 nithinv13 had a problem deploying to deployment-integ-test October 9, 2025 02:50 — with GitHub Actions Error
@aemada-aws aemada-aws changed the title feat: allow root level canary scripts files for Puppeteer versions 11 and greater feat(synthetics): allow root level canary scripts files for Puppeteer versions 11 and greater Oct 9, 2025
@nithinv13 nithinv13 force-pushed the puppeteer_packaging_structure branch from 235ecac to 2b7f8e8 Compare October 10, 2025 05:41
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 10, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 10, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 10, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aemada-aws
Copy link
Copy Markdown
Contributor

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/integration-test-deployment.yml without workflows permission

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 10, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35426 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: Required status check "validate-pr" is queued.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 10, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aemada-aws
Copy link
Copy Markdown
Contributor

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot added the queued label Oct 10, 2025
@mergify mergify bot merged commit 46fb2dc into aws:main Oct 10, 2025
32 of 33 checks passed
@mergify mergify bot removed the queued label Oct 10, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants