-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(stepfunctions-tasks): allow EcsRunTask on fargate and ec2 to set capacity provider strategy #35465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(stepfunctions-tasks): allow EcsRunTask on fargate and ec2 to set capacity provider strategy #35465
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
3a144ff
feat(stepfunctions-tasks): wip
go-to-k d4ba563
wip
go-to-k 9c4e544
wip
go-to-k 439f98a
docs
go-to-k 42115fa
docs
go-to-k a4abaa8
unit tests
go-to-k 74f9170
integ tets
go-to-k 2574785
README
go-to-k 15a2d03
integ
go-to-k 5620912
platform=linux/amd64 in docker
go-to-k 4a34f60
fargate integ
go-to-k e874755
integ
go-to-k 2097747
Merge branch 'main' into sfn-tasks-ecs-capacity
go-to-k 96a20a0
integ
go-to-k 5b538c4
readme
go-to-k f1de60d
integ
go-to-k 2db9236
docs
go-to-k ba80be9
readme
go-to-k dd83cee
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-ta…
go-to-k 5c3c47e
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-ta…
go-to-k aa48631
apply review
go-to-k 2d87a51
Merge branch 'main' into sfn-tasks-ecs-capacity
go-to-k 893b56f
Merge branch 'main' into sfn-tasks-ecs-capacity
go-to-k 99e5b7b
Merge branch 'main' into sfn-tasks-ecs-capacity
go-to-k 6fa325b
wip
go-to-k a4988d1
Revert "wip"
go-to-k 384f9ea
remove none
go-to-k 78556e7
Update run-task.ts
go-to-k 6720630
Update run-task.ts
go-to-k d19deb0
Update run-task.ts
go-to-k 3690e55
Update run-task.ts
go-to-k d1edace
Update run-task.ts
go-to-k 46ee32e
fix
go-to-k 5315695
tweak
go-to-k d0e3fd7
merge CapacityProviderOptions
go-to-k a92b88f
Merge pull request #2 from go-to-k/sfn-tasks-exp
go-to-k f688e3c
Merge branch 'main' into sfn-tasks-ecs-capacity
go-to-k d2ea76c
Update integ.ec2-run-task-capacity-provider.ts
go-to-k 4c9e8a7
Update integ.fargate-run-task-capacity-provider.ts
go-to-k c1d9bb0
Merge branch 'main' into sfn-tasks-ecs-capacity
Abogical dac3525
Merge branch 'main' into sfn-tasks-ecs-capacity
go-to-k 6a48a60
validation
go-to-k 4623178
Merge branch 'main' into sfn-tasks-ecs-capacity
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...sting/framework-integ/test/aws-stepfunctions-tasks/test/ecs/eventhandler-image/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| FROM public.ecr.aws/docker/library/python:3.12 | ||
| FROM --platform=linux/amd64 public.ecr.aws/docker/library/python:3.12 | ||
| ADD index.py . | ||
| CMD [ "python3", "./index.py" ] | ||
33 changes: 33 additions & 0 deletions
33
...shot/SfnTasksEcsEc2RunTaskCapacityProviderTestDefaultTestDeployAssertD08F9F1E.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because amd64 is used for cpu architecture in integ tests.
If this option is not specified, running the tests on Mac will result in an error during state machine execution.