Skip to content

docs: fix typos and wording in feature flags description#35789

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
garysassano:patch-1
Oct 31, 2025
Merged

docs: fix typos and wording in feature flags description#35789
mergify[bot] merged 4 commits intoaws:mainfrom
garysassano:patch-1

Conversation

@garysassano
Copy link
Copy Markdown
Contributor

@garysassano garysassano commented Oct 21, 2025 •
edited
Loading

Issue # (if applicable)

Closes #.

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 21, 2025 01:21
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 21, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@garysassano garysassano changed the title Fix wording in FEATURE_FLAGS.md for clarity docs: Fix wording in FEATURE_FLAGS.md for clarity Oct 21, 2025
@garysassano garysassano changed the title docs: Fix wording in FEATURE_FLAGS.md for clarity docs: Fix wording in FEATURE_FLAGS.md for clarity Oct 21, 2025
@ozelalisen ozelalisen self-assigned this Oct 21, 2025
@ozelalisen ozelalisen changed the title docs: Fix wording in FEATURE_FLAGS.md for clarity docs: fix wording in FEATURE_FLAGS.md for clarity Oct 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 21, 2025 06:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

ozelalisen
ozelalisen previously requested changes Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ozelalisen ozelalisen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Oct 21, 2025 •
edited
Loading

The file is generated from the source here: https://github.com/aws/aws-cdk/blob/main/packages%2Faws-cdk-lib%2Fcx-api%2Flib%2Ffeatures.ts

Don't change it by hand, they won't work.

rix0rrr
rix0rrr previously requested changes Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this file is generated from another data source (some .ts file somewhere).

Search the code base for that original string and edit the other one.

@mergify mergify bot dismissed stale reviews from rix0rrr and ozelalisen October 21, 2025 10:00

Pull request has been modified.

@garysassano garysassano changed the title docs: fix wording in FEATURE_FLAGS.md for clarity docs: fix typos and wording in features.ts Oct 26, 2025
ozelalisen
ozelalisen previously requested changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Build is failing, because you have uncommitted changes regarding FEATURE_FLAGS.md. You should include new generated FEATURE_FLAGS.md along with this PR

@mergify mergify bot dismissed ozelalisen’s stale review October 30, 2025 02:59

Pull request has been modified.

@garysassano garysassano changed the title docs: fix typos and wording in features.ts docs: fix typos and wording in feature flags description Oct 30, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@garysassano @mergify
Fix typos in features.ts documentation
36fa1da 
Corrected typos in feature flag documentation for clarity.
@garysassano @mergify
Update details for ASPECT_STABILIZATION feature
b1b7327 
Clarified the explanation of the stabilization loop for Aspects.
@garysassano @mergify
update FEATURE_FLAGS.md
c2a46f3
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit db057e1 into aws:main Oct 31, 2025
17 of 19 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ozelalisen ozelalisen ozelalisen approved these changes

@rix0rrr rix0rrr rix0rrr left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@ozelalisen ozelalisen

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@garysassano @mrgrain @rix0rrr @aws-cdk-automation @ozelalisen