Skip to content

chore(ecs): add new enum values for ecs#35806

Merged
mergify[bot] merged 5 commits intomainfrom
enum-update/ecs
Oct 29, 2025
Merged

chore(ecs): add new enum values for ecs#35806
mergify[bot] merged 5 commits intomainfrom
enum-update/ecs

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR updates the enum values for ecs.

@github-actions github-actions bot added contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Oct 21, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aemada-aws aemada-aws added the pr/do-not-merge This PR should not be merged at this time. label Oct 28, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35806 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • -label~=(blocked|do-not-merge|no-squash|two-approvers|priority-pr)
  • check-success=build
  • check-success=validate-pr
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • -label~=(blocked|do-not-merge|no-squash|priority-pr)
      • check-success=build
      • check-success=validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = validate-pr
        • check-skipped = validate-pr
        • check-success = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build
        • check-skipped = build
        • check-success = build.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aemada-aws
Copy link
Copy Markdown
Contributor

aemada-aws commented Oct 28, 2025

https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-resource-ecs-service.html#cfn-ecs-service-launchtype
The cfn resource does not support that value in launchType, when developing the feature it was mentioned that to use managed instances, it needs to be added as a capacity provider not as a service launch type. I will check with ECS team.

@Abogical Abogical self-requested a review October 28, 2025 15:09
@abidhasan-aws
Copy link
Copy Markdown
Contributor

PR has been updated to exclude the enum value "MANAGED_INSTANCES".

Reason for this exclusion:
Customers cannot pass launchType=MANAGED_INSTANCES and this value only appears in Describe calls. In order to use Amazon ECS Managed Instances, users must use capacityProviderStrategy request parameter and omit the launchType request parameter.

@aemada-aws aemada-aws removed the pr/do-not-merge This PR should not be merged at this time. label Oct 29, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9bec236 into main Oct 29, 2025
18 of 19 checks passed
@mergify mergify bot deleted the enum-update/ecs branch October 29, 2025 13:08
@github-actions
Copy link
Copy Markdown
Contributor Author

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants