feat(batch): add consumableResourceProperties to job definitions

[matoom-nomu]

Issue None

Reason for this change

AWS Batch Job Definitions now support Consumable Resource Properties, which allow jobs to specify and consume shared resources like software licenses or API call quotas. This feature was missing from the CDK construct library.

Description of changes

• Added support for consumableResourceProperties in AWS Batch Job Definitions
• Added ConsumableResourceProperties and ConsumableResource interfaces to define the structure
• Updated EcsJobDefinitionProps, EksJobDefinitionProps, and MultiNodeJobDefinitionProps to include the optional consumableResourceProperties field

Describe any new or updated permissions being added

None

Description of how you validated changes

• Added unit test.
• Added integration test.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[vishaalmehrishi]

The property definition (docs) requires that this resource must match a pattern: arn:[a-z0-9-\.]{1,63}:[a-z0-9-\.]{0,63}:[a-z0-9-\.]{0,63}:[a-z0-9-\.]{0,63}:[^/].{0,1023}

[matoom-nomu]

Thanks for review.
Sounds I'd prefer to make consumableResource L2 construct and pass IConsumableResource to job-definition, I'll make another PR to create consumableResource L2 construct first.

[matoom-nomu]

Thanks for review. Sounds I'd prefer to make consumableResource L2 construct and pass IConsumableResource to job-definition, I'll make another PR to create consumableResource L2 construct first.

↑ I made PR about this.
#36971 feat(batch): add ConsumableResource L2 construct

[vishaalmehrishi]

This needs token resolution validation + input validation to ensure the quantity is > 0

if (!Token.isUnresolved(req.quantity)) {
        if (req.quantity <= 0 || !Number.isInteger(req.quantity)) {
          throw new Error(
            `Consumable resource at index ${index} must have a positive integer quantity, got: ${req.quantity}`
          );
        }
      }

[vishaalmehrishi]

The what's new post says

you can associate up to 5 CRs with your AWS Batch jobs while creating or updating AWS Batch job definitions

I don't see this limit specified in the service quotas though. Is it possible to create a job with more than 5 consumable resources locally and check if it succeeds? If the limit is 5, the CDK code should add this validation.

[matoom-nomu]

The what's new post says

you can associate up to 5 CRs with your AWS Batch jobs while creating or updating AWS Batch job definitions

I don't see this limit specified in the service quotas though. Is it possible to create a job with more than 5 consumable resources locally and check if it succeeds? If the limit is 5, the CDK code should add this validation.

i confirmed CR configuration is limited to 5 per job definition in the management console.
and it seems there is no service quota configuration for it.
so i'll add validation about this as you say.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

• Resume work on the PR
• OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
• OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.