feat(codebuild): add support for macOS 15 runners#35836
feat(codebuild): add support for macOS 15 runners#35836mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Though the automated validation passes, I still have to add a snapshot for the base15 integration test. Update: generated and added. |
|
Hello, just bumping this PR. |
Pull request has been modified.
Signed-off-by: ayush-panta <ayushkp@amazon.com>
19389fe to
f1cae44
Compare
|
Hi @ozelalisen, thank you for your suggestions. I've made the necessary changes. |
|
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 4 seconds in the queue, with no time running CI. ReasonThe pull request can't be updated
HintYou should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 1f0a1d3 This pull request spent 5 hours 59 minutes 45 seconds in the queue, including 5 hours 59 minutes 35 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Although CodeBuild supports the macOS base:15 image (ref), the CDK does not support this.
Description of changes
I added an option for the BASE_15 image. This simply involved copying the logic for BASE_14 and changing 14 to 15.
Describe any new or updated permissions being added
NA.
Description of how you validated changes
I added unit and integration tests for the base:15 image following the example of the existing tests for the base:14 image.
Unit tests (aws-codebuild/test/project.test.ts) passed locally:
The integration tests (aws-codebuild/test/integ.project-macos-fleet-base{14/15}.js) were not as straightforward. In the CodeBuild stack logs in my console, the stacks were able to be created successfully but failed to delete. I believe this is expected with macOS fleets and for these test cases, especially as the base:14 test already existed in the codebase. I have included snapshots, as required.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license