feat(ec2): add Interface VPC Endpoints for ACM and ACM-PCA#35879
Closed
feat(ec2): add Interface VPC Endpoints for ACM and ACM-PCA#35879
Conversation
aws-cdk-automation
requested changes
Oct 28, 2025
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Contributor
Author
|
I'm closing this pull request because some necessary code changes were missing. |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
AWS supports Interface VPC Endpoints for ACM and ACM-PCA,
but AWS CDK currently only supports
acm-pca.This change adds missing support for
acm,acm-fips, andacm-pca-fips.Description of changes
Add interface VPC endpoints
acmacm-fipsacm-pca-fipsDescribe any new or updated permissions being added
None
Description of how you validated changes
Executed AWS CLI
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license