feat(eks): support MixedInstancePolicy for self-managed nodes#35921
Closed
chancepants wants to merge 2 commits intoaws:mainfrom
Closed
feat(eks): support MixedInstancePolicy for self-managed nodes#35921chancepants wants to merge 2 commits intoaws:mainfrom
chancepants wants to merge 2 commits intoaws:mainfrom
Conversation
Adds an optional parameter to the cluster addAutoScalingGroupCapacity method to support MixedInstancePolicy. Currently the only alternative is to heavily utilize escape hatches to attach a MixedInstancePolicy to the ASG created within this method.
github-actions
bot
added
effort/medium
aws-cdk-automation
requested changes
Nov 2, 2025
Collaborator
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional parameter to the cluster addAutoScalingGroupCapacity method to support MixedInstancePolicy. Currently the only alternative is to heavily utilize escape hatches to attach a MixedInstancePolicy to the ASG created within this method.
Issue # (if applicable)
Closes #35732
Reason for this change
Users of eks
cluster.addAutoScalingGroupCapcitydo not have a convenient way to apply a MixedInstancePolicy to their ASG.Description of changes
Added an optional parameter to
cluster.addAutoScalingGroupCapcityto allow users to provide a MixedInstancePolicy which is applied to the ASG.Description of how you validated changes
I added unit tests which largely cover the validation logic and added a unittest to verify CDK deployments succeed with the new parameter.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license