Skip to content

feat(eks): support MixedInstancePolicy for self-managed nodes#35923

Open
chancepants wants to merge 15 commits intoaws:mainfrom
chancepants:mixed-instances
Open

feat(eks): support MixedInstancePolicy for self-managed nodes#35923
chancepants wants to merge 15 commits intoaws:mainfrom
chancepants:mixed-instances

Conversation

@chancepants
Copy link
Copy Markdown

Adds an optional parameter to the cluster addAutoScalingGroupCapacity method to support MixedInstancePolicy. Currently the only alternative is to heavily utilize escape hatches to attach a MixedInstancePolicy to the ASG created within this method.

Issue # (if applicable)

Closes #35732

Reason for this change

Users of eks cluster.addAutoScalingGroupCapcity do not have a convenient way to apply a MixedInstancePolicy to their ASG.

Description of changes

Added an optional parameter to cluster.addAutoScalingGroupCapcity to allow users to provide a MixedInstancePolicy which is applied to the ASG.

Description of how you validated changes

I added unit tests which largely cover the validation logic and added a unittest to verify CDK deployments succeed with the new parameter.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Adds an optional parameter to the cluster addAutoScalingGroupCapacity
method to support MixedInstancePolicy. Currently the only alternative is
to heavily utilize escape hatches to attach a MixedInstancePolicy to the
ASG created within this method.
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Nov 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 2, 2025 02:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results96 ran95 passed1 failed
TestResult
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-mixed-instances.js.snapshot/aws-cdk-eks-cluster-mixed-instances-test.template.json
iam-no-world-accessible-trust-policy.guard❌ failure

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates96 ran93 passed3 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-mixed-instances.js.snapshot/aws-cdk-eks-cluster-mixed-instances-test.template.json
codepipeline-cross-account-role-trust-scope.guard❌ failure
guardhooks-no-root-principals-except-kms-secrets.guard❌ failure
iam-role-no-broad-principals.guard❌ failure

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-eks: AutoScalingGroupCapacityOptions - support MixedInstancesPolicy

2 participants