Conversation
|
FYI @pahud |
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ The title prefix of this pull request must be one of "feat|fix|build|chore|ci|docs|style|refactor|perf|test|revert"
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
|
This approach might not work: https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-amplify-domain-subdomainsetting.html#cfn-amplify-domain-subdomainsetting-prefix The |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35958
Reason for this change
After deploying a CDK stack containing an Amplify app with a custom domain that has a blank prefix, the underlying CloudFormation stack is immediately in "drifted" state.
Description of changes
Per the suggestions in the issue, I updated the
renderSubDomainSettingsmethod to omit thePrefixmethod from the resulting map when the supplied prefix is set to''.The existing fallback logic is preserved for falling back to
branchNameifprefixisnullorundefined.Describe any new or updated permissions being added
None.
Description of how you validated changes
Updated the corresponding test for mapping a branch to the domain root.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license