fix(events-targets): launchType not included for non-AWS_VPC network mode

[newlinedeveloper]

Description

Fixes an issue where the launchType property (including EXTERNAL) was being silently dropped from the CloudFormation template when creating an ECS event target with non-AWS_VPC network modes.

Root Cause

The EcsTask construct only included launchType in the EcsParameters when the task definition used AWS_VPC network mode. For other network modes (like BRIDGE, HOST, NONE), the launchType was omitted entirely from the generated CloudFormation template, causing EventBridge to use default launch type logic instead of the specified launch type.

This was particularly problematic for EXTERNAL launch type, which requires ECS Anywhere infrastructure. When the launch type was dropped, the scheduled task would fail to run because it would try to use EC2 or Fargate launch types instead of EXTERNAL.

Solution

Modified the bind() method in ecs-task.ts to always include launchType in baseEcsParameters, regardless of network mode. The launchType is now included in the CloudFormation template for all network modes, not just AWS_VPC.

Changes:

• Moved launchType from the conditional AWS_VPC branch into baseEcsParameters
• Ensures launchType is always included when specified (or computed from task definition compatibility)
• Network configuration (networkConfiguration) remains only for AWS_VPC network mode, as required by CloudFormation

Testing

• Added unit test launch type EXTERNAL is included for non-AWS_VPC network mode to verify the fix
• Added integration test integ.event-external-task.ts to verify the stack synthesizes correctly
• All existing unit tests continue to pass
• Verified that LaunchType: 'EXTERNAL' appears in the CloudFormation template for BRIDGE network mode

Related Issue

Fixes #35877

Verification

The fix was verified by:

1. Running unit tests to ensure LaunchType: 'EXTERNAL' is included in the CloudFormation template
2. Generating integration test snapshot to verify the stack synthesizes correctly
3. Confirming that existing tests for EC2 and Fargate launch types continue to pass
4. The change aligns with AWS CloudFormation documentation which supports LaunchType for all network modes

CloudFormation Template Change

Before:
"EcsParameters": {
"TaskCount": 1,
"TaskDefinitionArn": { "Ref": "TaskDef" }
}
After:
"EcsParameters": {
"TaskCount": 1,
"TaskDefinitionArn": { "Ref": "TaskDef" },
"LaunchType": "EXTERNAL"
}---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[newlinedeveloper]

Hi @pahud . This PR needs review and approval. Please check it out. Thanks

[pahud]

I just clicked CI approval button to trigger the CI run for this PR. After CI passes you should get pr/pending-community-review label and you are all set. Do not click Update branch after your PR is ready as this triggers another CI build attempt. Thank you.

[github-actions]

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

---

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results	48 ran	48 passed

Test	Result
No test annotations available

• View Security Guardian Results

[github-actions]

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

---

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results with resolved templates	48 ran	48 passed

Test	Result
No test annotations available

• View Security Guardian Results with resolved templates

[gasolima]

I want to test all the different NetworkMode with this setup. It can be done easily by encapsulating from line 12 to 32 to into cdk.Construct and add a single input to this construct NetworkMode and iterate over NetworkMode and pass the different values to this construct.

I'm just afraid of in the future a network mode add that doesn't accept external launch type and no one will think of this edge case.

Can you help us doing that?

Pull request has been modified.

[gasolima]

@newlinedeveloper the build is failing, let me know if u need help with this