Skip to content

chore(kms): support ML-DSA keys for keySpec#35991

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
aki-kii:kms-35990
Nov 10, 2025
Merged

chore(kms): support ML-DSA keys for keySpec#35991
mergify[bot] merged 5 commits intoaws:mainfrom
aki-kii:kms-35990

Conversation

@aki-kii
Copy link
Copy Markdown
Contributor

@aki-kii aki-kii commented Nov 9, 2025

Issue # (if applicable)

Closes #35990

Reason for this change

To support ML-DSA keys for KeySpec.

Description of changes

  • Add ML-DSA keys validation rule

Description of how you validated changes

Added both unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 9, 2025 03:19
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Nov 9, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aki-kii aki-kii changed the title feat(kms): support ML-DSA keys for keySpec chore(kms): support ML-DSA keys for keySpec Nov 9, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 9, 2025 03:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@ozelalisen ozelalisen self-assigned this Nov 10, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f7b5d8c into aws:main Nov 10, 2025
18 of 19 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature-request A feature should be added or improved. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-kms): Add support for ML-DSA keys

3 participants