feat(batch): skip unregister job definition on update by badmintoncryer · Pull Request #36011 · aws/aws-cdk

badmintoncryer · 2025-11-11T14:22:36Z

Issue # (if applicable)

None

Reason for this change

Cloudformation now supports for skipping unregister job definition on update.
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/TemplateReference/aws-properties-batch-jobdefinition-resourceretentionpolicy.html#cfn-batch-jobdefinition-resourceretentionpolicy-skipderegisteronupdate

Description of changes

add skipDeregisterOnUpdate to JobdefinitionProps

Describe any new or updated permissions being added

none

Description of how you validated changes

Add both unit and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

github-actions · 2025-12-06T04:42:53Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results	72 ran	72 passed

Test	Result
No test annotations available

View Security Guardian Results

github-actions · 2025-12-06T04:42:55Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results with resolved templates	72 ran	72 passed

Test	Result
No test annotations available

View Security Guardian Results with resolved templates

kumsmrit · 2026-03-20T11:13:31Z

packages/aws-cdk-lib/aws-batch/lib/job-definition-base.ts

+   *
+   * @default undefined - AWS Batch default is false
+   */
+  readonly skipDeregisterOnUpdate?: boolean;


Is this required to be defined on IJobDefinition, since this affects the CFN update-time retention behavior?

@kumsmrit You are exactly right. I've removed the definition from IJobDefinition.

This property only affects CFN update-time retention behavior and is not relevant for imported resources via fromJobDefinitionArn. Keep it on JobDefinitionProps and JobDefinitionBase only.

mergify · 2026-03-31T10:32:33Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-31T10:32:36Z

Merge Queue Status

✅ Entered queue — 2026-03-31 10:32 UTC · Rule: default-squash
🚫 Left the queue — 2026-03-31 10:32 UTC · at eb9e54c928cd35092542ca2d2be4db1292d45294

This pull request spent 9 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov-upload.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-03-31T10:36:24Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer · 2026-03-31T12:41:50Z

@mergify update

mergify · 2026-03-31T12:42:01Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov-upload.yml without workflows permission

badmintoncryer · 2026-03-31T12:44:39Z

@kumsmrit Could you please approve again?

Pull request has been modified.

mergify · 2026-03-31T14:23:30Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-31T14:23:36Z

mergify · 2026-03-31T14:28:07Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-31T15:18:55Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2026-03-31T15:19:21Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

badmintoncryer added 2 commits November 11, 2025 22:14

support for skip deregistration

e89c28c

add unit test and update readme

9f199e8

github-actions bot added the p2 label Nov 11, 2025

aws-cdk-automation requested a review from a team November 11, 2025 14:22

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 11, 2025

badmintoncryer added 2 commits November 12, 2025 09:21

add member

79c5df2

Merge branch 'main' into skip

04c6597

badmintoncryer changed the title ~~feat(batch): skip unregister job definition on update~~ feat(batch): ski unregister job definition on update Nov 12, 2025

badmintoncryer changed the title ~~feat(batch): ski unregister job definition on update~~ feat(batch): skip unregister job definition on update Nov 12, 2025

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 12, 2025

badmintoncryer added 2 commits November 19, 2025 16:51

Merge branch 'main' into skip

8f332c9

Merge branch 'main' into skip

394b6ef

github-actions bot mentioned this pull request Dec 1, 2025

Monthly PR metrics report #36251

Open

Merge branch 'main' into skip

3444b07

badmintoncryer added 4 commits December 22, 2025 07:29

Merge branch 'main' into skip

ba23603

Merge branch 'main' into skip

ccb3a72

Merge branch 'main' into skip

6bca4ba

Merge remote-tracking branch 'origin/main' into skip

8edb877

badmintoncryer temporarily deployed to automation March 18, 2026 00:31 — with GitHub Actions Inactive

badmintoncryer temporarily deployed to automation March 18, 2026 00:32 — with GitHub Actions Inactive

kumsmrit self-assigned this Mar 20, 2026

kumsmrit reviewed Mar 20, 2026

View reviewed changes

fix: remove skipDeregisterOnUpdate from IJobDefinition interface

69b9743

This property only affects CFN update-time retention behavior and is not relevant for imported resources via fromJobDefinitionArn. Keep it on JobDefinitionProps and JobDefinitionBase only.

badmintoncryer temporarily deployed to automation March 21, 2026 00:08 — with GitHub Actions Inactive

Merge branch 'main' into skip

52d874a

badmintoncryer temporarily deployed to automation March 21, 2026 00:10 — with GitHub Actions Inactive

badmintoncryer temporarily deployed to automation March 30, 2026 12:28 — with GitHub Actions Inactive

kumsmrit previously approved these changes Mar 31, 2026

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 31, 2026

aws-cdk-automation temporarily deployed to automation March 31, 2026 10:33 — with GitHub Actions Inactive

Merge branch 'main' into skip

2bb2747

badmintoncryer temporarily deployed to automation March 31, 2026 12:44 — with GitHub Actions Inactive

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 31, 2026

aws-cdk-automation temporarily deployed to automation March 31, 2026 13:30 — with GitHub Actions Inactive

kumsmrit approved these changes Mar 31, 2026

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 31, 2026

aws-cdk-automation temporarily deployed to automation March 31, 2026 14:25 — with GitHub Actions Inactive

Merge branch 'main' into skip

3124447

mergify bot temporarily deployed to automation March 31, 2026 14:48 Inactive

mergify bot merged commit 2fb2240 into aws:main Mar 31, 2026
25 of 26 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2026

Conversation

badmintoncryer commented Nov 11, 2025

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

github-actions bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kumsmrit Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

badmintoncryer Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 31, 2026

Uh oh!

mergify bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Mar 31, 2026

Uh oh!

badmintoncryer commented Mar 31, 2026

Uh oh!

mergify bot commented Mar 31, 2026

❌ Mergify doesn't have permission to update

Uh oh!

badmintoncryer commented Mar 31, 2026

Uh oh!

mergify bot commented Mar 31, 2026

Uh oh!

mergify bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

mergify bot commented Mar 31, 2026

Uh oh!

mergify bot commented Mar 31, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 6, 2025 •

edited

Loading

github-actions bot commented Dec 6, 2025 •

edited

Loading

mergify bot commented Mar 31, 2026 •

edited

Loading

mergify bot commented Mar 31, 2026 •

edited

Loading