chore: centralize storage of submodule names#36018
Merged
mergify[bot] merged 5 commits intomainfrom Nov 12, 2025
Merged
Conversation
rix0rrr
approved these changes
Nov 12, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
Currently,
.jsiirc.jsonfiles in aws-cdk-lib submodules contain historical naming deviations (e.g.,Amazon.CDK.AWS.Sagemakerinstead of the standardAmazon.CDK.AWS.SageMaker). These files are manually maintained and scattered across hundreds of subdirectories, making it:This creates technical debt and makes it harder to evolve the codebase.
Description of changes
Centralizes all jsii target configurations into a single
scope-map.jsonfile that serves as the source of truth. The submodule generation script now always regenerates.jsiirc.jsonfiles from this central configuration, ensuring consistency and making deviations explicit and auditable.Supporting changes:
module-topology.tsto manage the scope maputil/pkglint.tstoutil/jsii.tscfn2tsCLI toolThis makes historical deviations visible in one place and prevents future drift.
Describe any new or updated permissions being added
No new permissions are being added.
Description of how you validated changes
Basically the proof that this works is that (aside from
scope-map.json) only codegen files have changed. In particularjsii-diffdoesn't report anything and no.jsiirc.jsonfiles changed.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license