chore(spec2cdk): add explicit return type to loadPatchedSpec#36031
Merged
mergify[bot] merged 1 commit intomainfrom Nov 12, 2025
Merged
chore(spec2cdk): add explicit return type to loadPatchedSpec#36031mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
aws-cdk-automation
previously requested changes
Nov 12, 2025
mrgrain
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
svidgen
approved these changes
Nov 12, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
The
loadPatchedSpecfunction was missing an explicit return type annotation, which caused the integration test PRs in https://github.com/cdklabs/awscdk-service-spec to fail (example).This is a fairly obscure scenario and doesn't happen that often. But I don't really have a good way to prevent this kind of issue in future. For now, let's stop the bleeding.
Description of changes
Added explicit
Promise<SpecDatabase>return type annotation to theloadPatchedSpecfunction intools/@aws-cdk/spec2cdk/lib/generate.ts.Describe any new or updated permissions being added
None.
Description of how you validated changes
Type-only change, verified manually with linked
awscdk-service-specpackages.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license