chore(interfaces): submodule names for interface submodules are incorrect#36036
Merged
mergify[bot] merged 1 commit intomainfrom Nov 13, 2025
Merged
chore(interfaces): submodule names for interface submodules are incorrect#36036mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
mrgrain
changed the title
mrgrain
added
pr-linter/cli-integ-tested
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
mrgrain
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
mrgrain
commented
Nov 13, 2025
Contributor
Author
There was a problem hiding this comment.
just adding some comments for better understanding
rix0rrr
reviewed
Nov 13, 2025
mrgrain
commented
Nov 13, 2025
| const ns = `${interfacesModuleJsiiRc.targets[language][whatName]}.${lastPart(submodule.definition?.[k] ?? 'undefined')}`; | ||
| if (ns.includes('undefined')) { | ||
| throw new Error(`Could not build child namespace for language ${language} from ${JSON.stringify(interfacesModuleJsiiRc.targets[language])} and ${k} from ${JSON.stringify(submodule.definition)}`); | ||
| function combineLanguageNamespace(language: string, whatName: string, fromDef?: string) { |
Contributor
Author
There was a problem hiding this comment.
this seemed overly complicated just to get the key name into the error message
rix0rrr
reviewed
Nov 13, 2025
| const ns = `${interfacesModuleJsiiRc.targets[language][whatName]}.${lastPart(submodule.definition?.[k] ?? 'undefined')}`; | ||
| if (ns.includes('undefined')) { | ||
| throw new Error(`Could not build child namespace for language ${language} from ${JSON.stringify(interfacesModuleJsiiRc.targets[language])} and ${k} from ${JSON.stringify(submodule.definition)}`); | ||
| function combineLanguageNamespace(language: string, whatName: string, fromDef?: string) { |
mrgrain
force-pushed
the
mrgrain/chore/fix-interfaces-go
branch
from
13d332a to
11ade54
Compare
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
approved these changes
Nov 13, 2025
mrgrain
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
Collaborator
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
Go packaging was failing with
However as it turns out the generated
jsiircwere using the wrong path. They were missing the required.(fullstop) prefix, thus the written package names were not being considered by jsii at all.For go, we also need to update the interfaces package name to a unique name:
Before:
After:
Description of changes
Use the correct
jsiircfilename.Ensure a unique package name for go is used.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Test pipeline is passing. Manually tested go packaging.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license