Skip to content

chore(cloudfront): add missing regions to PRICE_CLASS_200 documentation#36039

Open
sAchin-680 wants to merge 1 commit intoaws:mainfrom
sAchin-680:feature/cloudfront-price-class-200-docs
Open

chore(cloudfront): add missing regions to PRICE_CLASS_200 documentation#36039
sAchin-680 wants to merge 1 commit intoaws:mainfrom
sAchin-680:feature/cloudfront-price-class-200-docs

Conversation

@sAchin-680
Copy link
Copy Markdown
Contributor

@sAchin-680 sAchin-680 commented Nov 13, 2025 •
edited
Loading

Issue # (if applicable)

Closes #35992

Reason for this change

The JSDoc comment for PRICE_CLASS_200 was missing several regions that are actually included in this price class according to the official AWS CloudFront pricing documentation, causing confusion for developers about which regions are covered.

Description of changes

Updated the JSDoc comment for PRICE_CLASS_200 in packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts to include the missing regions: India, Indonesia, Thailand, Malaysia, Vietnam, Nigeria, Egypt, and Türkiye.

This is a documentation-only change that adds accurate region information to help developers understand the full scope of PRICE_CLASS_200 coverage.

Reference: AWS CloudFront Pricing — This page lists all regions included in each price class.

Describe any new or updated permissions being added

None - this is a documentation-only change.

Description of how you validated changes

  • Verified the updated documentation matches the official AWS CloudFront pricing page
  • Confirmed the change only affects JSDoc comments with no code logic changes
  • Existing test coverage (lines 937-948 in distribution.test.ts) validates the enum value
  • Checked that the file builds without errors

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 13, 2025 13:07
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 13, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@sAchin-680 sAchin-680 mentioned this pull request Nov 13, 2025
Open
@pahud pahud mentioned this pull request Nov 13, 2025
Open
@github-actions github-actions bot mentioned this pull request Dec 1, 2025
Open
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 5, 2025

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025 •
edited
Loading

TestsPassed ❌️SkippedFailed
Security Guardian Results0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025 •
edited
Loading

TestsPassed ❌️SkippedFailed
Security Guardian Results with resolved templates0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

@sAchin-680
Copy link
Copy Markdown
Contributor Author

sAchin-680 commented Dec 5, 2025

Hi @pahud !

Exemption Request: Documentation-only change updating the JSDoc comment for PRICE_CLASS_200 to include all regions per AWS CloudFront pricing docs. No code logic modified. Existing test (lines 937-948 in distribution.test.ts already validates the enum value.

Please review when possible. Fixes #35992.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Dec 5, 2025
@pahud pahud changed the title fix(cloudfront): add missing regions to PRICE_CLASS_200 documentation chore(cloudfront): add missing regions to PRICE_CLASS_200 documentation Dec 5, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 5, 2025 18:11

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@pahud
Copy link
Copy Markdown
Contributor

pahud commented Dec 5, 2025 •
edited
Loading

@sAchin-680 I am not eligible to review PRs but I can make sure your PR is ready and move into the queue.

include all regions per AWS CloudFront pricing docs

Do you have the AWS docs link? If yes, can you include in the PR description as this will help the maintainer give a very quick approval.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 5, 2025
@pahud
Copy link
Copy Markdown
Contributor

pahud commented Dec 5, 2025

Thank you. I can confirm that this PR is now in the pr/needs-community-review queue. Once it receives an approving community review, it will move to the pr/needs-maintainer-review stage. Please ensure that the CI status remains in a Success state, as the maintainer will review it from that queue.

@sAchin-680
Copy link
Copy Markdown
Contributor Author

sAchin-680 commented Dec 6, 2025

Do you have the AWS docs link? If yes, can you include in the PR description as this will help the maintainer give a very quick approval.

Thank you, @pahud!

Yes, the official AWS CloudFront pricing documentation link is:
https://aws.amazon.com/cloudfront/pricing/

I believe this is the correct reference, but please correct me if I’m wrong.
I’ll add this link to the PR description as suggested.

@sAchin-680
fix(cloudfront): add missing regions to PRICE_CLASS_200 documentation
9f1cb81 
Include India, Indonesia, Thailand, Malaysia, Vietnam, Nigeria, Egypt, and Türkiye in the PRICE_CLASS_200 JSDoc comment to accurately reflect all regions covered by this price class.

Closes aws#35992

Signed-off-by: SACHIN KUMAR <mrmister680@gmail.com>
@sAchin-680 sAchin-680 force-pushed the feature/cloudfront-price-class-200-docs branch from b551bc9 to 9f1cb81 Compare January 8, 2026 10:14
@pahud
Copy link
Copy Markdown
Contributor

pahud commented Jan 12, 2026 •
edited
Loading

If the CodeBuild CI passes, this PR will be moved to pr/needs-community-review queue and you are all set.

Don't merge from main branch after this point unless you encounter conflicts—doing so will require another approving CI run. Thank you.

@sAchin-680
Copy link
Copy Markdown
Contributor Author

sAchin-680 commented Jan 13, 2026

If the CodeBuild CI passes, this PR will be moved to pr/needs-community-review queue and you are all set.

Don't merge from main branch after this point unless you encounter conflicts—doing so will require another approving CI run. Thank you.

Thanks for the update @pahud !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws_cdk.aws_cloudfront : India is missing from PRICE_CLASS_200

3 participants

@sAchin-680 @aws-cdk-automation @pahud