fix(bedrock-agentcore-alpha): empty submodule accidentally exposed

[rix0rrr]

perms.ts is accidentally being exported. It only contains a namespace with static const arrays of strings, which are of no use to jsii consumers. These represent IAM actions that are being set inside the library, and don't need to be public to begin with.

Move the file into a directory called private to make it clear it should not be exported, and remove it from the jsii entry point.

Solves this:

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[krokoko]

@rix0rrr I am working on another PR to fix this
Instead of moving to private I'm removing the namespace, since it can cause issues in other target languages
would that work for you ?

[krokoko]

#36148

[rix0rrr]

Instead of moving to private I'm removing the namespace, since it can cause issues in other target languages

I'm not sure what "it can cause issues" means. The namespace leads to a submodule, which is "fine", though overkill.

But the contents of that namespace/submodule are free constants, and jsii will not pick those up; primarily because they cannot be represented in Java and C#, where everything must be associated with a class.

You could replace the namespace with an abstract class which only exists to hold public static readonly values... but why have these arrays of strings in the first place? Other construct libraries don't have these either, so why would yours?

[rix0rrr]

While I've got you here, can you also move all the files from the agentcore/ directory into the lib/ directory?

I'm not sure why lib/index.ts reads:

export * from '../agentcore';

Even though those files could equally well just be in lib directly.

[krokoko]

but why have these arrays of strings in the first place? Other construct libraries don't have these either, so why would yours?

We had these following the implementation in constructs like https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-s3/lib/perms.ts

[krokoko]

While I've got you here, can you also move all the files from the agentcore/ directory into the lib/ directory?

I'm not sure why lib/index.ts reads:

export * from '../agentcore';

Even though those files could equally well just be in lib directly.

Done in the PR listed above, removed /agentcore and moved files under /lib. Waiting for build to finish

[alvazjor]

#36148 approved

[rix0rrr]

We had these following the implementation in constructs like https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-s3/lib/perms.ts

That's fine, perms.ts in s3 is not exposed publicly though:

(This predates the convention that we explicitly marked non-exported files as private)

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.