Merged
Conversation
…#36175) The `ScheduleGroup.grant*()` methods are delegating to the methods in the auto-generated `ScheduleGroupGrants` class. This class is generating policies with an incorrect ARN. Instead of: ``` arn:aws:scheduler:<region>:xxx:schedule/my-group-name/* ``` it is generating: ``` arn:aws:scheduler:<region>:xxx:schedule-group/my-group-name/* ``` Since the code generation mechanism doesn't provide any way of specifying a custom logic for the ARN generation, replace the auto-generated `ScheduleGroupGrants` with hand-written one, in which the ARN is computed by: ```ts private arnForScheduleInGroup(scheduleName: string): string { return Arn.format({ region: this.resource.env.region, account: this.resource.env.account, partition: Aws.PARTITION, service: 'scheduler', resource: 'schedule', resourceName: this.resource.scheduleGroupRef.scheduleGroupName + '/' + scheduleName, }); } ``` Fixes #36165. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
added
auto-approve
pr/no-squash
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aws-cdk-automation
added
the
pr/needs-maintainer-review
Contributor
Merge Queue Status
✅ The pull request has been merged This pull request spent 28 minutes 1 second in the queue, including 27 minutes 51 seconds waiting for CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CHANGELOG