Skip to content

fix(ecs-patterns): target group ID changes without setting feature flag#36199

Merged
mergify[bot] merged 3 commits intomainfrom
alb-group-id-change-hotfix
Nov 26, 2025
Merged

fix(ecs-patterns): target group ID changes without setting feature flag#36199
mergify[bot] merged 3 commits intomainfrom
alb-group-id-change-hotfix

Conversation

@Abogical
Copy link
Copy Markdown
Member

@Abogical Abogical commented Nov 25, 2025

Issue # (if applicable)

Closes #36149

Reason for this change

The feature flag did not stop the target group ID of the ALB to change if the load balancer was private.

Description of changes

The target group ID will not change if the feature flag is not set and remain as ECS.

Describe any new or updated permissions being added

No new permissions are added.

Description of how you validated changes

Unit test added.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 25, 2025 22:03
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p0 labels Nov 25, 2025
@Abogical Abogical added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 25, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 25, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Abogical Abogical changed the title fix(ecs-patterns): Keep legacy target group ID when not setting feature flag fix(ecs-patterns): keep legacy target group ID when not setting feature flag Nov 25, 2025
@Abogical Abogical changed the title fix(ecs-patterns): keep legacy target group ID when not setting feature flag fix(ecs-patterns): target group ID changes without setting feature flag Nov 25, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 25, 2025 22:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Abogical Abogical added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Nov 25, 2025
@Abogical Abogical had a problem deploying to deployment-integ-test November 25, 2025 22:39 — with GitHub Actions Failure
This was referenced Nov 25, 2025
Closed
Closed
@Abogical Abogical removed the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Nov 25, 2025
@Abogical
Copy link
Copy Markdown
Member Author

Abogical commented Nov 25, 2025 •
edited
Loading

There seems to be a bug with the deployment integ runner, cancelling workflow and deploying locally instead. The workflow will not block the merge.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 25, 2025
@Abogical
Copy link
Copy Markdown
Member Author

Abogical commented Nov 25, 2025

Test snapshots deployed successfully on the local machine.

@ozelalisen ozelalisen self-assigned this Nov 26, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025 •
edited
Loading

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 41 minutes 17 seconds in the queue, including 41 minutes 3 seconds waiting for CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b7ca082 into main Nov 26, 2025
17 of 18 checks passed
@mergify mergify bot deleted the alb-group-id-change-hotfix branch November 26, 2025 10:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 26, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ozelalisen ozelalisen ozelalisen approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@ozelalisen ozelalisen

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p0 pr-linter/exempt-integ-test The PR linter will not require integ test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws_ecs_patterns): upgrading past 2.221.0 caused outage as target group was recreated

3 participants

@Abogical @aws-cdk-automation @ozelalisen