feat(aws-cdk-lib): add arnFor<ResourceName> for 47 more resources#36231
Merged
mergify[bot] merged 2 commits intomainfrom Dec 1, 2025
Merged
feat(aws-cdk-lib): add arnFor<ResourceName> for 47 more resources#36231mergify[bot] merged 2 commits intomainfrom
arnFor<ResourceName> for 47 more resources#36231mergify[bot] merged 2 commits intomainfrom
Conversation
aws-cdk-automation
previously requested changes
Nov 27, 2025
5e6c194 to
2c3d8af
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
2c3d8af to
d79cbcc
Compare
d79cbcc to
0528641
Compare
arnForResource for x more resourcesarnForResource for 47 more resources
arnForResource for 47 more resourcesarnForResource for 47 more resources
arnForResource for 47 more resourcesarnFor<ResourceName> for 47 more resources
arnFor<ResourceName> for 47 more resourcesarnFor<ResourceName> for 47 more resources
rix0rrr
approved these changes
Dec 1, 2025
Contributor
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
Today, out of
1512resources,892have anarnFor${Resource}getter function (~58%).The reasons are varied, but it comes done to us not being able to identify the required resource properties in an automated way.
Description of changes
We are adding a few additional heuristics to the matching:
37additional resources)ARN(all caps). (9additional resources)AgentRuntimeinstead of the expectedRuntime. We extract this prefix from a primary identifier if it is ending inId. (2additional resources)This brings our total count to
939or~62%. A little better!PR also includes a major refactor of how reference props and now arn getters are organized. A lot of code depends on this information, so best to centralize the logic for it.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing and additional tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license