feat(lambda): support for application signals layers#36235
Open
nikovirtala wants to merge 1 commit intoaws:mainfrom
Open
feat(lambda): support for application signals layers#36235nikovirtala wants to merge 1 commit intoaws:mainfrom
nikovirtala wants to merge 1 commit intoaws:mainfrom
Conversation
aws-cdk-automation
previously requested changes
Nov 28, 2025
4beed7a to
ff0f5c3
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
Author
|
Now that I'm looking at the implementation, it could've also been simply a boolean |
ff0f5c3 to
3dfd465
Compare
Contributor
Author
|
I would like the API to clearly distinguish the wrapper used by Application Signals, but What's the idiomatic way in |
c34111d to
8c10a69
Compare
8c10a69 to
bd016e3
Compare
bd016e3 to
031f123
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #36190
Reason for this change
I wanted to provide the
aws-cdk-libLambda Function constructs users an easy way to start using Amazon CloudWatch Application Signals.Description of changes
I added new regional facts for the layer ARNs and the methods to find the correct layer for the specified
Runtime, with necessary compatibility checks.Describe any new or updated permissions being added
The usage requires attaching a policy to the Lambda execution IAM Role. I left it intentionally as a manual step, but I want to discuss with the maintainer whether it could be abstracted away. I thought it will be easier around the code?
Description of how you validated changes
Unit and integration tests are covering the implementation.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license