Upgrade crt 0.28.4 #9831
Merged
Upgrade crt 0.28.4 #9831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashovlin
approved these changes
Nov 6, 2025
Member
ashovlin
left a comment
ashovlin
left a comment
There was a problem hiding this comment.
Diff looks good. Hit retry on some of the flaky failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
awscrtto0.28.4.awslabs/aws-crt-python#686 added validation to ensure that
awscrt.io.init_loggingisn't called more than once since it's not thread-safe. This PR addresses the break by changing theenable_crt_logginganddisable_crt_loggingfunctions to useaws.io.set_log_levelinstead and initializes CRT logging once at the top.