Skip to content

feat: Add POCOs for S3 object events#1073

Merged
normj merged 3 commits intoaws:devfrom
rpf3:s3event
Feb 12, 2023
Merged

feat: Add POCOs for S3 object events#1073
normj merged 3 commits intoaws:devfrom
rpf3:s3event

Conversation

@rpf3
Copy link
Copy Markdown

@rpf3 rpf3 commented Feb 3, 2022

This commit adds POCOs to model S3 object events routed via EventBridge.

closes #1072

@ashishdhingra ashishdhingra added the pr/needs-review This PR needs a review from a Member. label Feb 16, 2022
@ashishdhingra
Copy link
Copy Markdown
Contributor

ashishdhingra commented Feb 24, 2022

@rpf3 It would be nice to add some test cases as well. Please refer existing ones as a reference.

@ashishdhingra
Copy link
Copy Markdown
Contributor

ashishdhingra commented Mar 22, 2022

@rpf3 Also refer https://docs.aws.amazon.com/AmazonS3/latest/userguide//ev-events.html, detail could have additional details based on operation. Few examples:

  • deletion-type for delete operation
  • restore-expiry-time and source-storage-class for object restore completed.

S3ObjectEventDetails class perhaps needs to be modeled accordingly, perhaps might want to create subclasses for each scenario.

@ashishdhingra ashishdhingra added the response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. label Mar 22, 2022
@ashishdhingra ashishdhingra added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Apr 7, 2022
@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. label Apr 7, 2022
@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. labels Apr 7, 2022
@ashishdhingra ashishdhingra added the response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. label May 23, 2022
@ashishdhingra ashishdhingra mentioned this pull request May 23, 2022
Closed
Richard P. Field III added 2 commits May 30, 2022 10:40
feat: Add POCOs for S3 object events
eeee4f9 
This commit adds POCOs to model S3 object events routed via EventBridge.
fix: Only manually rename JSON props in .NET 3.1
7b63df4
feat: Create multiple S3 object event models
d4f6dce 
This commit adds models for all the EventBridge S3 object event types.
@rpf3
Copy link
Copy Markdown
Author

rpf3 commented May 30, 2022

@ashishdhingra I've pushed some new models as you requested. Is this more in line with what you were thinking?

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. label May 31, 2022
@ashishdhingra
Copy link
Copy Markdown
Contributor

ashishdhingra commented Jul 7, 2022

@ashishdhingra I've pushed some new models as you requested. Is this more in line with what you were thinking?

@rpf3 Thanks. Could you also add some unit tests as well as requested in #1073 (comment).

@ashishdhingra ashishdhingra added feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. labels Oct 11, 2022
@normj normj changed the base branch from master to dev February 12, 2023 01:11
@normj normj merged commit 265f48b into aws:dev Feb 12, 2023
@normj
Copy link
Copy Markdown
Member

normj commented Feb 12, 2023

I manually added unit tests, change size to be a long from an int and added DataContract attributes to fix serialization with Newtonsoft. I'll work on getting this PR released soon.

@normj
Copy link
Copy Markdown
Member

normj commented Feb 13, 2023

This PR has been released as part of version 4.1.0 of Amazon.Lambda.CloudWatchEvents. Thanks for the PR!

@rpf3 rpf3 deleted the s3event branch February 13, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature-request A feature should be added or improved. pr/needs-review This PR needs a review from a Member. response-requested Waiting on additional info and feedback. Will move to close soon in 7 days.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

S3 Events with EventBridge

3 participants

@rpf3 @ashishdhingra @normj