Merged
Conversation
normj
requested changes
Feb 28, 2023
Member
normj
left a comment
normj
left a comment
There was a problem hiding this comment.
We need a unit test for this new POCO. You can look at the CloudWatchEventsS3ObjectCreate test as an example.
| namespace Amazon.Lambda.CloudWatchEvents.TranscribeEvents | ||
| { | ||
| /// <summary> | ||
| /// This class represents the details of a Transcribe Job State Change sent via EventBridge. |
Member
There was a problem hiding this comment.
Is the a URL you can add to where this event type is documented?
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Sorry I wasn't clear, can you add the URL as part of the NDoc here?
normj
requested changes
Feb 28, 2023
| namespace Amazon.Lambda.CloudWatchEvents.TranscribeEvents | ||
| { | ||
| /// <summary> | ||
| /// This class represents the details of a Transcribe Job State Change sent via EventBridge. |
Member
There was a problem hiding this comment.
Sorry I wasn't clear, can you add the URL as part of the NDoc here?
normj
approved these changes
Feb 28, 2023
Member
|
PR has been released as part of version 4.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds Transcribe Job State Change Event.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.