Skip to content

fix incorrect type#1523

Merged
ashishdhingra merged 2 commits intoaws:devfrom
jpgrusling:master
Jun 8, 2023
Merged

fix incorrect type#1523
ashishdhingra merged 2 commits intoaws:devfrom
jpgrusling:master

Conversation

@jpgrusling
Copy link
Copy Markdown
Contributor

Based on the documentation at https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-verify-auth-challenge-response.html#cognito-user-pools-lambda-trigger-syntax-verify-auth-challenge, the current type is incorrect. This fixes and local testing confirms resolution.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Copy Markdown
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed the ChallengeAnswer was mismodeled. Could you update this test JSON file

and then this test case
Assert.Equal(2, cognitoVerifyAuthChallengeEvent.Request.ChallengeAnswer.Count);

@normj normj changed the base branch from master to dev June 7, 2023 21:08
@ashishdhingra ashishdhingra self-requested a review June 7, 2023 21:10
Copy link
Copy Markdown
Contributor

@ashishdhingra ashishdhingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@normj
Copy link
Copy Markdown
Member

normj commented Jun 9, 2023

Version 2.1.1 of Amazon.Lambda.CognitoEvents has been released with this PR. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants