Refactored APIGatewayProxyFunction.cs to enhance expandability#32
Merged
normj merged 1 commit intoaws:masterfrom Jan 14, 2017
thedevopsmachine:master
Merged
Refactored APIGatewayProxyFunction.cs to enhance expandability#32normj merged 1 commit intoaws:masterfrom thedevopsmachine:master
normj merged 1 commit intoaws:masterfrom
thedevopsmachine:master
Conversation
…FunctionHandlerAsync into reusable protected functions. This will allow developers to override FunctionHandlerAsync but reuse the other components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code to extract request processing logic from the virtual FunctionHandlerAsync into reusable protected functions. This will allow developers to override FunctionHandlerAsync but reuse the other components.
Also changed the private fields to readonly and changed the constructor accessor from public to protected. Since it's an abstract method, no need for a public constructor.