Skip to content

Contract resolvers are stateless. Reuse them#518

Merged
normj merged 1 commit intoaws:masterfrom
danielmarbach:json-contract-resolvers
Oct 24, 2019
Merged

Contract resolvers are stateless. Reuse them#518
normj merged 1 commit intoaws:masterfrom
danielmarbach:json-contract-resolvers

Conversation

@danielmarbach
Copy link
Copy Markdown
Contributor

ContractResolvers are stateless and can be reused.

Decided to use the AwsResolver as the root object for the converters and use a simple pattern to initialize the fields once

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Copy Markdown
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I post back when I get the PR released.

@normj normj merged commit 5f42cfb into aws:master Oct 24, 2019
@normj
Copy link
Copy Markdown
Member

normj commented Oct 25, 2019

Version 1.7.0 of Amazon.Lambda.Serialization.Json has been released with this PR.

@danielmarbach
Copy link
Copy Markdown
Contributor Author

Nice. Less allocations in AWS makes us all happy campers 😁👍

@danielmarbach danielmarbach deleted the json-contract-resolvers branch October 25, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants