Replace legacy DeleteItem params#4364
Conversation
irina-herciu
left a comment
There was a problem hiding this comment.
make sure all changes are covered with unit tests
|
|
||
| private Task DeleteHelperAsync<[DynamicallyAccessedMembers(InternalConstants.DataModelModeledType)] T>(T value, DynamoDBFlatConfig flatConfig, CancellationToken cancellationToken) | ||
| { | ||
| if (value == null) throw new ArgumentNullException("value"); |
There was a problem hiding this comment.
extract common logic for sync and async
|
@irina-herciu @aanton-git I apologize but today's release included a massive refactoring of the SDK integration tests. I updated them to: use xUnit for parallelism, target .NET 8 in addition to .NET Framework, and (for DynamoDB specifically) split the large document / data model tests into separate classes (new structure is https://github.com/aws/aws-sdk-net/tree/main/sdk/test/Services/DynamoDBv2/IntegrationTests). Unfortunately you'll need to rebase your branches, but hopefully this change makes adding new tests / troubleshooting easier in the future (not to mention actually testing non |
1459ec3 to
28d3796
Compare
28d3796 to
f258868
Compare
Description
DeleteAsync<[DynamicallyAccessedMembers(InternalConstants.DataModelModeledType) ends up in DeleteHelperAsync<[DynamicallyAccessedMembers(InternalConstants.DataModelModeledType), which still uses legacy Expected and ConditionalOperator. AWS recommends ConditionExpression instead. Update delete request construction to use expression-based conditions.
Motivation and Context
• Context.Async.cs:184 → DeleteAsync<[DynamicallyAccessedMembers(InternalConstants.DataModelModeledType)
• Context.cs → DeleteHelperAsync<[DynamicallyAccessedMembers(InternalConstants.DataModelModeledType)
• Table.cs → DeleteHelperAsync<[DynamicallyAccessedMembers(InternalConstants.DataModelModeledType) builds DeleteItemRequest
Testing
-feature branch mocked client benchmarks
-development branch mocked client benchmarks
Breaking Changes Assessment
Screenshots (if appropriate)
Types of changes
Checklist
License