Replace AttributesToGet usage with ProjectionExpression for batch get requests#4392
Open
irina-herciu wants to merge 2 commits intoaws:developmentfrom
Open
Replace AttributesToGet usage with ProjectionExpression for batch get requests#4392irina-herciu wants to merge 2 commits intoaws:developmentfrom
irina-herciu wants to merge 2 commits intoaws:developmentfrom
Conversation
Contributor
|
Is this the same as #4343? (And if yes, should that PR be closed?) |
Contributor
Author
|
this PR targets BatchGet operations, and #4343 is for load item operation. there is indeed code duplication as I needed to build and pass ProjectionExpression from ItemStorageConfig |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
AttributesToGetusage withProjectionExpressionfor batch get requests created from the DynamoDB data model layer, and add tests aroundDocumentBatchGetbehavior.Description
ProjectionExpressionfromItemStorageConfigintoDocumentBatchGetProjectionExpressionorAttributesToGet, and throws if both are set,DocumentBatchGet.Motivation and Context
Replace legacy params usage in HLL
Testing
Unit tests added, all existing integration tests passing
Dry-runs
Breaking Changes Assessment
Screenshots (if appropriate)
Types of changes
Checklist
License